Added makeGroup(), fixed CFVariable indexing and $summarise()`

Author: pvanlaake

NAMESPACE

@@ -35,6 +35,7 @@ export(groups)
 export(makeAxis)
 export(makeCharacterAxis)
 export(makeDiscreteAxis)
+export(makeGroup)
 export(makeLatitudeAxis)
 export(makeLongitudeAxis)
 export(makeTimeAxis)

R/CFVariable.R

@@ -710,7 +710,7 @@ CFVariable <- R6::R6Class("CFVariable",
         stop("The 'time' axis is too short to summarise on.", call. = FALSE) # nocov
       if (is.factor(f)) f <- list(f)
 
-      tm <- sum(private$YXZT() > 0L) # Test which oriented axes are present, T is the last one
+      tm <- which(names(private$.axes) == tax$name)
 
       # Private group for the result
       grp <- CFGroup$new("", NULL)
@@ -1205,6 +1205,8 @@ CFVariable <- R6::R6Class("CFVariable",
           private$.id <- private$.NCobj$id
         } else {
           pack <- private$.NCobj$is_packed
+          ax_names <- names(private$.axes)
+          scalars <- rep(FALSE, length(ax_names))
         }
 
         # Packing attributes
@@ -1217,7 +1219,7 @@ CFVariable <- R6::R6Class("CFVariable",
 
         # Set "coordinates" attribute for scalar axes and labels
         if (any(scalars) || length(lbls))
-          self$set_attribute("coordinates", "NC_CHAR", paste(c(names(private$.axes[scalars]), lbls), collapse = " "))
+          self$set_attribute("coordinates", "NC_CHAR", paste(c(ax_names[scalars], lbls), collapse = " "))
 
         private$write_data(dt, pack = pack, na.mode = 2)
         private$.dirty <- FALSE
@@ -1439,6 +1441,8 @@ dimnames.CFVariable <- function(x) {
 #' summer <- pr[, , 173:263]
 #' str(summer)
 "[.CFVariable" <- function(x, i, j, ..., drop = FALSE) {
+  caller_env <- parent.frame()
+
   numaxes <- x$ndims
   t <- vector("list", numaxes)
   names(t) <- dimnames(x)[1:numaxes]
@@ -1473,7 +1477,7 @@ dimnames.CFVariable <- function(x) {
           if (!is.null(tm)) t[[d]] <- tm
         } else {
           # Subset the axis
-          v <- eval(sc[[d]])
+          v <- eval(sc[[d]], envir = caller_env)
           ex <- range(v)
           start[d] <- ex[1L]
           count[d] <- ex[2L] - ex[1L] + 1L

R/makeCFObjects.R

@@ -17,9 +17,27 @@ create_ncdf <- function() {
   ds
 }
 
+#' Create a new group
+#'
+#' This function creates a new group for CF objects. Groups are organized in an
+#' hierarchy, starting with a root node. A root node is specified by an empty
+#' string for a name and with argument `parent_group = NULL`.
+#' @param name A name for the group. This must be a valid name for CF objects.
+#' The default value is the empty string "".
+#' @param parent_group Optionally, a parent for the current group. This must be
+#' an instance of `CFGroup` itself.
+#' @return A new instance of `CFGroup`.
+#' @export
+#' @examples
+#' root <- makeGroup()
+#' sub_group <- makeGroup("sub", root)
+makeGroup <- function(name = "", parent_group = NULL) {
+  CFGroup$new(name, parent_group)
+}
+
 #' Create an axis
 #'
-#' With this method you can create an axis to use with new [CFVariable]
+#' With this function you can create an axis to use with new [CFVariable]
 #' instances. Depending on the `orientation` argument and the type of the
 #' `values` argument an instance of a class descending from [CFAxis] will be
 #' returned.