Make usesPkce a derived property on RestSourceClient#333
Open
this-Aditya wants to merge 3 commits into
Open
Conversation
| val scope: String? = null, | ||
| val state: String? = null, | ||
| val usesPkce: Boolean = false, | ||
| val oauthVersion: String = "oauth2", |
Member
There was a problem hiding this comment.
if it only supports 2 values, would it be better as an enum class then ?
Member
Author
There was a problem hiding this comment.
Yeah, good point.
Would it be nice, if we just keep this as boolean instead, something like isOauth2 to keep it simple?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive
usesPkcein rest source client and remove it from constructor param so it can never be added to the configs.