Updated SourceRowView to display icons for plugins#141
Open
this-Aditya wants to merge 1 commit into
Open
Conversation
this-Aditya
force-pushed
the
dev
branch
3 times, most recently
from
61d7fac to
7e20fe0
Compare
| private fun updateSourceIcon(status: SourceStatusListener.Status) { | ||
| pluginImageResource = imageResourceRef(status) | ||
| if (pluginImageResource != -1) { | ||
| mBatteryLabel.setImageResource(pluginImageResource) |
Member
There was a problem hiding this comment.
would it make sense to rename the variable mBatteryLabel since it is not just for battery level anymore?
Member
Author
There was a problem hiding this comment.
Nice point, but I think the related PR in radar-commons-android was already closed a long time ago, I just missed closing it here.
If I add this again now, it will likely introduce another merge conflict in the ktor-coroutines PR, which already has quite a few conflicts and probably needs some rework as well. I’m thinking of picking that up a bit later.
Would it be okay if we add this functionality at that time instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Custom Item for each plugin. With Support for different icons for different connection states of a plugin.
prmt.mp4
Supporting PR from radar-commons-android -> RADAR-base/radar-commons-android#445