Skip to content

Commit 204eefd

Browse files
committed
Nurbs Example Fixes
1 parent f33460b commit 204eefd

20 files changed

Lines changed: 11 additions & 5 deletions

nurbs.scad

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -641,50 +641,56 @@ module debug_nurbs(control,degree,splinesteps=16,width=1, size, mult,weights,typ
641641
// data = [[0,0], [10,30], [25,15], [40,35], [60,10], [80,25]];
642642
// path = nurbs_curve(nurbs_interp(data, 3));
643643
// stroke(path);
644+
// color("red") move_copies(data) circle(r=1, $fn=16);
644645
//
645646
// Example(2D): Closed curve - Do NOT repeat the first point at the end.
646647
// data = [[0,0], [30,50], [60,40], [80,10], [50,-20], [20,-10]];
647648
// path = nurbs_curve(nurbs_interp(data, 3, closed = true));
648649
// stroke(path, closed = true);
650+
// color("red") move_copies(data) circle(r=0.25, $fn=16);
649651
//
650652
// Example(2D): Closed polygon - All data points lie exactly on the polygon boundary.
651653
// data = [[0,0], [30,50], [60,40], [80,10], [50,-20], [20,-10]];
652654
// path = nurbs_curve(nurbs_interp(data, 3, closed=true), splinesteps=16);
653655
// polygon(path);
654-
// color("red") move_copies(data) circle(r=0.25, $fn=16);
656+
// color("red") move_copies(data) circle(r=1, $fn=16);
655657
//
656658
// Example(2D): Get just the path
657659
// data = [[0,0], [10,30], [25,15], [40,35], [60,10], [80,25]];
658660
// path = nurbs_curve(nurbs_interp(data, 3), splinesteps=16);
659661
// stroke(path, width=0.5);
660-
// color("red") move_copies(data) circle(r=0.25, $fn=16);
662+
// color("red") move_copies(data) circle(r=1, $fn=16);
661663
//
662664
// Example(2D): Low-level NURBS parameter list - nurbs_interp() returns a BOSL2 NURBS parameter list compatible with nurbs_curve(), debug_nurbs(), etc.
663665
// data = [[0,0], [10,30], [25,15], [40,35], [60,10], [80,25]];
664666
// result = nurbs_interp(data, 3);
665667
// curve = nurbs_curve(result, splinesteps=24);
666668
// stroke(curve, width=0.5);
669+
// color("red") move_copies(data) circle(r=1, $fn=16);
667670
//
668671
// Example(3D): 3D closed curve
669672
// data3d = [[20,0,0],[0,20,10],[-20,0,20],[0,-20,10]];
670673
// path = nurbs_curve(nurbs_interp(data3d, 3, closed=true));
671674
// stroke(path, width=1, closed=true);
672-
// color("red") move_copies(data3d) sphere(r=0.25, $fn=16);
675+
// color("red") move_copies(data3d) sphere(r=1, $fn=16);
673676
//
674677
// Example(2D): Corner added at data point 3
675678
// data = [[0,0], [10,30], [25,15], [40,35], [60,10], [80,25]];
676679
// path = nurbs_curve(nurbs_interp(data, 3, corners = [3]));
677680
// stroke(path);
681+
// color("red") move_copies(data) circle(r=1, $fn=16);
678682
//
679683
// Example(2D): Controlling the curvature at data point 3
680684
// data = [[0,0], [10,30], [25,15], [40,35], [60,10], [80,25]];
681685
// path = nurbs_curve(nurbs_interp(data, 3));
682686
// stroke(path);
687+
// color("red") move_copies(data) circle(r=1, $fn=16);
683688
//
684689
// Example(2D): Clamped curve (default)
685690
// data = [[0,0], [10,30], [25,15], [40,35], [60,10], [80,25]];
686691
// path = nurbs_curve(nurbs_interp(data, 3));
687692
// stroke(path);
693+
// color("red") move_copies(data) circle(r=1, $fn=16);
688694
//
689695
// Example(2D,Med): Endpoint tangent control - Specify start and/or end tangent vectors. Each vector is automatically scaled by the total chord length; a unit vector produces natural arc-length speed. Magnitude > 1 increases pull, < 1 weakens it.
690696
// data = [[0,0], [20,30], [50,25], [80,0]];
@@ -1038,7 +1044,7 @@ module debug_nurbs_interp(points, degree, splinesteps=16, method="centripetal",
10381044

10391045

10401046
// Function: nurbs_elevate_degree()
1041-
// Synopsis: Raises the degree of a closed or open NURBS.
1047+
// Synopsis: Raises the degree of a clamped or open NURBS.
10421048
// Topics: NURBS Curves
10431049
// See Also: nurbs_interp(), nurbs_curve()
10441050
//
@@ -1047,7 +1053,7 @@ module debug_nurbs_interp(points, degree, splinesteps=16, method="centripetal",
10471053
// result = nurbs_elevate_degree(nurbs_param_list, [times=]);
10481054
//
10491055
// Description:
1050-
// Raises the degree of a "closed" or "open" NURBS by `times` steps, producing
1056+
// Raises the degree of a "clamped" or "open" NURBS by `times` steps, producing
10511057
// a geometrically identical curve at the higher degree. Returns a NURBS parameter list
10521058
// of the form `[type, degree, control_points, knots, undef, weights]` that can be
10531059
// passed directly to {{nurbs_curve()}} and other NURBS functions. The returned `mult`

tmp_cuboid_10.png

-20.8 KB
Binary file not shown.

tmp_prismoid_2200000.png

-22 KB
Binary file not shown.

tmp_prismoid_2200001.png

-26 KB
Binary file not shown.

tmp_prismoid_2200002.png

-27.3 KB
Binary file not shown.

tmp_prismoid_2200003.png

-28.8 KB
Binary file not shown.

tmp_prismoid_2200004.png

-29.2 KB
Binary file not shown.

tmp_prismoid_2200005.png

-28.4 KB
Binary file not shown.

tmp_prismoid_2200006.png

-26.3 KB
Binary file not shown.

tmp_prismoid_2200007.png

-26.5 KB
Binary file not shown.

0 commit comments

Comments
 (0)