Fix flaky ClaimTypesConst tests#171
Merged
Merged
Conversation
…mbly ClaimTypesConstTests.Configure_AppliesCustomValues intermittently failed on CI (seeing the default role claim URI instead of the configured "roles"). Root cause is a cross-class race on the process-wide mutable static ClaimTypesConst: both ClaimTypesConstTests and ClaimsIdentityExtensionsTests call the internal Reset() in ctor/Dispose, and under xUnit's default per-class parallelism a parallel Reset() can null the options mid-test so a later property read rebuilds defaults. Disable test parallelization for RCommon.Security.Tests so the shared static state is deterministic. Pre-existing flake, unrelated to the 3.1.1 changes; it blocked the release CI run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClaimTypesConstTests.Configure_AppliesCustomValues intermittently failed on CI (seeing the default role claim URI instead of the configured "roles"). Root cause is a cross-class race on the process-wide mutable static ClaimTypesConst: both ClaimTypesConstTests and ClaimsIdentityExtensionsTests call the internal Reset() in ctor/Dispose, and under xUnit's default per-class parallelism a parallel Reset() can null the options mid-test so a later property read rebuilds defaults.
Disable test parallelization for RCommon.Security.Tests so the shared static state is deterministic. Pre-existing flake, unrelated to the 3.1.1 changes; it blocked the release CI run.