Skip to content

docs: fix some typos and trim whitespace #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeis4wpi wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −26
Open

docs: fix some typos and trim whitespace #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions tests/testthat/_snaps/property.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
Code
print(x)
Output
<S7_property>
<S7_property>
$ name : chr "foo"
$ class : <S7_base_class>: <integer>
$ getter : NULL
Expand All @@ -108,7 +108,7 @@
str(list(x))
Output
List of 1
$ : <S7_property>
$ : <S7_property>
..$ name : chr "foo"
..$ class : <S7_base_class>: <integer>
..$ getter : NULL
Expand All @@ -126,12 +126,12 @@
@ constructor: function(anything, null, base, S3, S4, S7, S7_union) {...}
@ validator : <NULL>
@ properties :
$ anything: <ANY>
$ null : <NULL>
$ base : <integer>
$ S3 : S3<factor>
$ S4 : S4<class_S4>
$ S7 : <class_S7>
$ anything: <ANY>
$ null : <NULL>
$ base : <integer>
$ S3 : S3<factor>
$ S4 : S4<class_S4>
$ S7 : <class_S7>
$ S7_union: <integer> or <logical>

---
Expand Down Expand Up @@ -215,30 +215,30 @@
! <foo> object properties are invalid:
- @x must be length 1

# prop<- won't infinitly recurse on a custom setter
# prop<- won't infinitely recurse on a custom setter

Code
obj <- foo()
Output
Starting syncup with value:
Starting syncup with value:
setting @a <- "a_"
setting @b <- "b_"
Starting syncup with value: b_
Starting syncup with value: b_
setting @a <- "a_b_"
setting @b <- "b_b_"
Starting syncup with value:
Starting syncup with value:
setting @a <- "a_"
Starting syncup with value: a_
Starting syncup with value: a_
setting @a <- "a_a_"
setting @b <- "b_a_"
setting @b <- "b_"
Code
obj@a <- "val"
Output
Starting syncup with value: val
Starting syncup with value: val
setting @a <- "a_val"
setting @b <- "b_val"
Starting syncup with value: b_val
Starting syncup with value: b_val
setting @a <- "a_b_val"
setting @b <- "b_b_val"

Expand All @@ -247,30 +247,30 @@
Code
receiver <- Receiver()
Output
[rx] receiving:
[rx] receiving:
[rx] finished receiving.
Code
transmitter <- Transmitter()
Output
[tx] sending:
[rx] receiving:
[tx] sending:
[rx] receiving:
[rx] finished receiving.
[tx] saving last sent message.
[tx] finished transmitting.
Code
transmitter@message <- "hello"
Output
[tx] sending: hello
[rx] receiving: hello
[tx] sending: hello
[rx] receiving: hello
[rx] finished receiving.
[tx] saving last sent message.
[tx] finished transmitting.
Code
expect_equal(receiver@message, "hello")
transmitter@message <- "goodbye"
Output
[tx] sending: goodbye
[rx] receiving: goodbye
[tx] sending: goodbye
[rx] receiving: goodbye
[rx] finished receiving.
[tx] saving last sent message.
[tx] finished transmitting.
Expand Down
8 changes: 4 additions & 4 deletions tests/testthat/test-property.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ describe("property retrieval", {
expect_snapshot_error(prop(obj, "x"))
expect_snapshot_error(obj@x)
})
it("evalutes dynamic properties", {
it("evaluates dynamic properties", {
foo <- new_class(
"foo",
properties = list(
Expand Down Expand Up @@ -444,7 +444,7 @@ test_that("can validate with custom validator", {
})
})

test_that("prop<- won't infinitly recurse on a custom setter", {
test_that("prop<- won't infinitely recurse on a custom setter", {
chattily_sync_ab <- function(self, value) {
cat("Starting syncup with value:", value, "\n")
a_value <- paste0("a_", value)
Expand Down Expand Up @@ -569,7 +569,7 @@ test_that("custom setters can call custom getters", {
})


test_that("custom getters don't evaulate call objects", {
test_that("custom getters don't evaluate call objects", {
QuotedCall := new_class(
class_call,
properties = list(
Expand All @@ -593,7 +593,7 @@ test_that("custom getters don't evaulate call objects", {
})


test_that("custom setters don't evaulate call objects", {
test_that("custom setters don't evaluate call objects", {
Call := new_class(
class_call,
properties = list(
Expand Down
Loading