Only use more specific convert methods#670
Open
hadley wants to merge 1 commit into
Open
Conversation
lawremi
approved these changes
Jun 1, 2026
Collaborator
lawremi
left a comment
lawremi
left a comment
There was a problem hiding this comment.
Thanks for fixing this, much appreciated.
hadley
commented
Jun 1, 2026
| from_dispatch <- obj_dispatch(from) | ||
| to_class <- class_register(to) | ||
|
|
||
| for (i in seq_along(from_dispatch)) { |
Member
Author
There was a problem hiding this comment.
Actually is this correct? Shouldn't it only consider an exact match? (i.e. no inheritance at all?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #429
@lawremi does this do what you expect?