isolib: strip terminal polarity markers from formulas before isotopic parsing#758
Open
Copilot wants to merge 7 commits into
Open
isolib: strip terminal polarity markers from formulas before isotopic parsing#758Copilot wants to merge 7 commits into
Copilot wants to merge 7 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix polarity handling in formulas for isotopic patterns
isolib: strip terminal polarity markers from formulas before isotopic parsing
Jun 2, 2026
Member
|
@copilot limit the strip to only +X or -X, because otherwise you might not be sure whether the previous digit refers to the number of atoms of the last type or so ... normally there should only be + and - without any digits. The test case looks good and can stay like this. |
Contributor
Author
Updated in commit 2148512. The regex now strips only sign-led terminal suffixes ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isolibfailed on formulas containing polarity/charge suffixes (+/-forms), even though polarity does not affect isotopic pattern generation. This change normalizes formula strings beforeenviPatparsing so charged input representations are handled consistently.Formula preprocessing (R runtime)
compound_table$formulainparse_args()by removing only terminal sign-led charge/polarity suffixes.+,-,+2,-2(with optional trailing whitespace context at end of string).Regression coverage (Galaxy tool tests)
tools/isolib/test-data/markers_no_rt_polarity.tsvwith formulas carrying polarity suffixes.tools/isolib/isolib.xmlthat runs this input and asserts equivalence with existing expected output (test1.msp), confirming polarity markers are ignored for isotopic pattern computation.