refactor: rename default fallback workspace key to '_default_'

Author: randy3k

R/languageserver.R

@@ -68,7 +68,7 @@ LanguageServer <- R6::R6Class("LanguageServer",
 
             self$pending_replies <- collections::dict()
             self$workspaces <- collections::dict()
-            self$workspaces$set("", Workspace$new(NULL))
+            self$workspaces$set("_default_", Workspace$new(NULL))
 
             super$initialize()
         },
@@ -84,15 +84,15 @@ LanguageServer <- R6::R6Class("LanguageServer",
             }
         },
         add_workspace = function(uri) {
-            key <- if (length(uri) == 0) "" else uri
+            key <- if (length(uri) == 0) "_default_" else uri
             if (!self$workspaces$has(key)) {
                 path <- if (length(uri) == 0) NULL else path_from_uri(uri)
                 new_workspace <- Workspace$new(path)
                 self$workspaces$set(key, new_workspace)
-                
+
                 # Remove documents from the fallback workspace if they belong here
                 if (!is.null(path)) {
-                    fallback <- self$workspaces$get("")
+                    fallback <- self$workspaces$get("_default_")
                     for (doc_uri in fallback$documents$keys()) {
                         doc_path <- path_from_uri(doc_uri)
                         if (path_has_parent(doc_path, path)) {
@@ -103,15 +103,17 @@ LanguageServer <- R6::R6Class("LanguageServer",
             }
         },
         remove_workspace = function(uri) {
-            key <- if (length(uri) == 0) "" else uri
-            if (key == "") return(invisible(NULL))
+            key <- if (length(uri) == 0) "_default_" else uri
+            if (key == "_default_") {
+                return(invisible(NULL))
+            }
             if (self$workspaces$has(key)) {
                 workspace <- self$workspaces$get(key)
                 for (doc_uri in workspace$documents$keys()) {
                     diagnostics_callback(self, doc_uri, NULL, list())
                     doc <- workspace$documents$get(doc_uri)
                     if (isTRUE(doc$is_open)) {
-                        self$workspaces$get("")$documents$set(doc_uri, doc)
+                        self$workspaces$get("_default_")$documents$set(doc_uri, doc)
                     }
                 }
                 self$workspaces$remove(key)
@@ -120,15 +122,17 @@ LanguageServer <- R6::R6Class("LanguageServer",
         get_workspace = function(uri) {
             workspaces_list <- self$workspaces$values()
 
-            default_key <- if (length(self$rootUri) == 0) "" else self$rootUri
-            default_workspace <- self$workspaces$get(default_key, self$workspaces$get(""))
+            default_key <- if (length(self$rootUri) == 0) "_default_" else self$rootUri
+            default_workspace <- self$workspaces$get(default_key, self$workspaces$get("_default_"))
 
-            if (length(uri) == 0) return(default_workspace)
+            if (length(uri) == 0) {
+                return(default_workspace)
+            }
 
             path <- path_from_uri(uri)
             best_match <- NULL
             max_len <- -1
-            
+
             for (workspace in workspaces_list) {
                 root <- workspace$root
                 if (length(root) > 0 && path_has_parent(path, root)) {
@@ -138,7 +142,7 @@ LanguageServer <- R6::R6Class("LanguageServer",
                     }
                 }
             }
-            
+
             best_match %||% default_workspace
         },
         load_workspace = function(workspace) {
@@ -163,8 +167,7 @@ LanguageServer <- R6::R6Class("LanguageServer",
                 self$load_workspace(workspace)
             }
         },
-        text_sync = function(
-                             uri, document, run_lintr = FALSE, parse = FALSE, delay = 0) {
+        text_sync = function(uri, document, run_lintr = FALSE, parse = FALSE, delay = 0) {
             if (!self$pending_replies$has(uri)) {
                 self$pending_replies$set(uri, list(
                     `textDocument/documentSymbol` = collections::queue(),