Align openapi with code structs#104
Conversation
There was a problem hiding this comment.
Pull request overview
Updates openapi.yaml to better reflect the Rust API request/response structs (per Issue #103), improving OpenAPI code generation compatibility and schema accuracy.
Changes:
- Added
requiredlists across many schemas to match non-optional Rust fields. - Tightened numeric schemas (e.g.,
fee_rate,amount) by switching somenumberfields tointegerand adding formats/min/max constraints. - Aligned certain schema shapes/names with the code (e.g.,
proxy_endpoint, usingAssignmentin more places).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
d3591a7 to
2ec1369
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
2ec1369 to
d8ef37f
Compare
|
The problem on tests is from the race condition I mentioned on #105 , I think we can merge this one untill I work on that issue |
zoedberg
left a comment
There was a problem hiding this comment.
Thanks. Please address the requested changes
d8ef37f to
d273577
Compare
d273577 to
a89db70
Compare
|
I fixed and rebased on master, let me know if any thing else requires changes |
a89db70 to
92edca0
Compare
zoedberg
left a comment
There was a problem hiding this comment.
we are almost there, but it seems you forgot to define required in ListAssetsResponse
92edca0 to
876a8cb
Compare
| properties: | ||
| file: | ||
| type: string | ||
| format: binary |
There was a problem hiding this comment.
Just to make sure, since you asked me to remove the format fields, do you want to keep this one or we can also drop this?
From my understanding, we have to keep this one since string doesn't explain it properly
There was a problem hiding this comment.
If I recall correctly without this the swagger interface does not render correctly, but I would appreciate if you could check this
There was a problem hiding this comment.
I checked, having it is better.
876a8cb to
8fb7087
Compare
|
Sorry this is taking so long, I did a careful review on the changes, let me know what you do you think on my last comment and then we can proceed, thanks |
… with Rust struct definitions
8fb7087 to
de0ffac
Compare
This Pr propose changes to openapi.yaml to match them more closely to what end-points expect.
Issue defined here #103