fix: improve bitcoind startup wait logic#109
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the regtest startup script to avoid a race where electrs can start before bitcoind’s RPC interface is ready, causing early failures during local regtest bring-up.
Changes:
- Switch
_wait_for_bitcoindfrom log-grepping to an RPC readiness check viabitcoin-cli getblockchaininfo. - Start
bitcoindfirst, initialize the mining wallet/blocks, then startelectrsandproxy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
zoedberg
requested changes
Mar 12, 2026
Member
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
thanks. please see the requested changes and comments
Co-authored-by: Zoe Faltibà <7492268+zoedberg@users.noreply.github.com>
Arshia-r-m
force-pushed
the
electrs-race-condition
branch
from
e4eaa7e to
1d8c9ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to handle the race condition between electrs and bitcoind where electrs starts before the rpc is fully ready