Skip to content

fix: improve bitcoind startup wait logic #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoedberg merged 1 commit into from
Mar 13, 2026
Merged

fix: improve bitcoind startup wait logic #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions regtest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ _is_port_bound() {
}

_wait_for_bitcoind() {
# wait for bitcoind to be up
# wait until bitcoind RPC is actually ready
start_time=$(date +%s)
until $COMPOSE logs bitcoind |grep -q 'Bound to'; do
until $BITCOIN_CLI getblockchaininfo >/dev/null 2>&1; do
current_time=$(date +%s)
if [ $((current_time - start_time)) -gt $TIMEOUT ]; then
echo "Timeout waiting for bitcoind to start"
echo "Timeout waiting for bitcoind RPC to become ready"
$COMPOSE logs bitcoind
exit 1
fi
Expand Down Expand Up @@ -74,11 +74,13 @@ _start_services() {
_die "port $port is already bound, services can't be started"
fi
done
$COMPOSE up -d
# start bitcoind first to avoid depending services failing due to RPC unavailability
$COMPOSE up -d bitcoind
echo && echo "preparing bitcoind wallet"
_wait_for_bitcoind
$BITCOIN_CLI createwallet miner >/dev/null
$BITCOIN_CLI -rpcwallet=miner -generate $INITIAL_BLOCKS >/dev/null
$COMPOSE up -d
echo "waiting for electrs to have completed startup"
_wait_for_electrs
}
Expand Down
Loading