fix ChannelPending Panic#112
Closed
bitwalt wants to merge 1 commit intoRGB-Tools:masterfrom
Closed
Conversation
Member
|
I cannot consider the test valid since it's doing a manual hack (setting |
bitwalt
force-pushed
the
rln-channelpending-panic
branch
3 times, most recently
from
194b12c to
446729c
Compare
Member
|
On my side the new test is failing. Here the logs: |
bitwalt
force-pushed
the
rln-channelpending-panic
branch
2 times, most recently
from
a49204f to
45b4ae7
Compare
Contributor
Author
|
The test is now passing, let me know if we can auto-release the lock if has been locked for more than 30 secs, or we should use another approach |
Member
|
No, auto-releasing the lock is not safe. We need to find where it needs to be set to false. Is the analysis reported in #111 correct? Is a panic actually happening during the |
Contributor
Author
|
Yes #111 analysis is correct |
Member
|
I tried the test without the "fix" and I don't see any panic. What panic do you see? |
bitwalt
force-pushed
the
rln-channelpending-panic
branch
2 times, most recently
from
1725cb9 to
0fd5b66
Compare
Contributor
Author
|
Reworked the PR based on your feedback: Removed the 30s auto-release timeout Regarding the panic question — the lock gets stuck even without a panic. The issue is that |
Member
|
I tried the test without the fix but it passes, we need a bug to be proven before thinking about the fix About
the reasoning here has some issues. The lock should be released after calling the send end method. Before that it can be released only if errors arise. |
Open a vanilla channel from node1 to node2, shut down node2 before the funding TX is mined (ChannelPending never fires), then verify that node1 cannot open a new channel to node3 because rgb_send_lock is never released. The ChannelClosed event handler does not reset rgb_send_lock, leaving the node permanently unable to open new channels. Ref: RGB-Tools#111
bitwalt
force-pushed
the
rln-channelpending-panic
branch
from
0fd5b66 to
731bceb
Compare
Contributor
Author
|
on my env the test is failing but i saw on the pipeline is not. i will close this PR and reopening it, if I'll find a way to replicate the issue |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reproduce and fix #111