Skip to content

feat: support for inflatable fungible assets#113

Merged
zoedberg merged 1 commit intoRGB-Tools:masterfrom
markuslevonyak:support-for-inflatable-fungible-assets
Mar 26, 2026
Merged

feat: support for inflatable fungible assets#113
zoedberg merged 1 commit intoRGB-Tools:masterfrom
markuslevonyak:support-for-inflatable-fungible-assets

Conversation

@markuslevonyak
Copy link
Copy Markdown
Contributor

Adds support for inflatable fungible assets (IFA).

Copy link
Copy Markdown
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!
Just a couple of notes:

  • lint is faling, there are a couple of methods that need to add #[allow(clippy::too_many_arguments)] on top
  • in src/error.rs there is an impl From<RgbLibError> for APIError block, where we could add the mapping of some common inflate errors (e.g. UnsupportedInflation, NoInflationAmounts)

I also merged RGB-Tools/rust-lightning#22 so you can revert the changes to .gitmodules

@markuslevonyak markuslevonyak force-pushed the support-for-inflatable-fungible-assets branch from 7b3820d to bfeb557 Compare March 26, 2026 04:58
@markuslevonyak
Copy link
Copy Markdown
Contributor Author

Thanks, this looks great! Just a couple of notes:

  • lint is faling, there are a couple of methods that need to add #[allow(clippy::too_many_arguments)] on top
  • in src/error.rs there is an impl From<RgbLibError> for APIError block, where we could add the mapping of some common inflate errors (e.g. UnsupportedInflation, NoInflationAmounts)

I also merged RGB-Tools/rust-lightning#22 so you can revert the changes to .gitmodules

Thanks! I've taken care of all your comments and pushed the changes.

@zoedberg zoedberg merged commit fa2aebd into RGB-Tools:master Mar 26, 2026
12 checks passed
@markuslevonyak markuslevonyak deleted the support-for-inflatable-fungible-assets branch March 26, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants