Fix private-channel swap routing#124
Merged
zoedberg merged 2 commits intoRGB-Tools:masterfrom Apr 30, 2026
Merged
Conversation
zoedberg
requested changes
Apr 29, 2026
Member
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
Thanks! Please address the requested changes and check the swap_assets_liquidity_both_ways test which seems to fail both on the CI and locally
bitwalt
force-pushed
the
private-channel-swap-routing
branch
from
1ec01bd to
720795f
Compare
bitwalt
force-pushed
the
private-channel-swap-routing
branch
from
720795f to
21cc5cf
Compare
Contributor
Author
|
Changes should have been addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
first_hopswhen route finding starts from our own nodeRoot Cause
The swap route lookup did not provide LDK with local first-hop channels. That works for public channels discoverable from graph data, but private channels are not in the public graph, so route finding could fail with
No route foundeven when a usable local private channel exists.Validation
cargo fmt --checkcargo checkcargo test test::swap_reverse_same_channel::swap_reverse_private_same_channel -- --exact --test-threads=1 --nocaptureFixes #123