Add push_asset_amount to OpenChannelRequest and update validation logic#69
Conversation
30b9dbf to
7f638ea
Compare
zoedberg
left a comment
There was a problem hiding this comment.
Thanks, please address the requested changes
d82e0b7 to
1f8116b
Compare
|
ok fixes should have been addressed, there was a problem on full-push case that required changes also in rust-lightning due to non-zero opener local balance |
zoedberg
left a comment
There was a problem hiding this comment.
Please see the requested change. Also please add some more checks/actions (payments, close channel, spend on-chain) after opening the channel with a push amount
1f8116b to
fb17583
Compare
|
Test updated with more checks (keysend, closing, spending on-onchain) |
nicbus
left a comment
There was a problem hiding this comment.
I think tests need to be further improved.
zoedberg
left a comment
There was a problem hiding this comment.
@bitwalt please address #69 (comment) and rebase the commit on top of the updated master
0f87740 to
b70b080
Compare
|
Changes has been addressed. Let me know if there are other required changes. |
b70b080 to
9dfa995
Compare
On my PC the test
LDK should handle this, but feel free to do more tests/checks if you think there might be problems. |
25ddcbb to
28b7a47
Compare
Made-with: Cursor
28b7a47 to
d419b04
Compare
push_asset_amountfield in OpenChannelRequest struct to handle asset pushes in RGB channels.push_asset_amountis only used with RGB channels and does not exceedasset_amount.push_asset_amount.push_asset_amountfunctionality and error conditions.Closes #67