feat(lab5): ZAP baseline + auth + Semgrep + correlation + fixed scripts#5
Merged
Conversation
Signed-off-by: Dmitrii Creed <creeed22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds the complete Lab 5 submission, including DAST/SAST analysis and the bonus correlation task, along with necessary fixes to the provided scripts.
Changes
zap-auth.yaml: Updated thereportDirto/zap/wrk/results/so the authenticated scan can successfully save its output.compare_zap.sh: Modified the script to accept CLI arguments for file paths and fixed the site filtering logic to correctly match3000(instead oflocalhost:3000).submissions/lab5.md:/rest/products/search) with a SAST rule (express-sequelize-injectionatroutes/search.ts:23), including the parameterized query fix.Testing
lab5-netnetwork.zap-baseline.pyandzap-auth.yamlscans againsthttp://juice-shop:3000.semgrepwith OWASP Top 10 rules locally against a fresh clone of thev20.0.0Juice Shop source code.compare_zap.shscript accurately counts risk severities.Artifacts & Screenshots
Checklist