fixup! sys/net/unicoap: properly handle options with value zero

Author: mguetschow

tests/unittests/tests-unicoap/tests-unicoap-options.c

@@ -383,24 +383,25 @@ static void test_remove_multiple(void)
     _TEST_ASSERT_EQUAL_BYTES(options_blob, unicoap_options_data(&options), sizeof(options_blob));
 }
 
-static void test_shortest_uint_in_option_value(void)
+static void test_option_value_uses_shortest_possible_representation(void)
 {
     static const uint8_t options_blob[] = { 0x00 };
     const unicoap_option_number_t OPTION_NUMBER = 0; // RESERVED
+    const uint32_t OPTION_VALUE = 0;
     UNICOAP_OPTIONS_ALLOC_STATIC(options, 10);
-    TEST_ASSERT_EQUAL_INT(0, unicoap_options_add_uint(&options, OPTION_NUMBER, 0));
+    TEST_ASSERT_EQUAL_INT(0, unicoap_options_add_uint(&options, OPTION_NUMBER, OPTION_VALUE));
     TEST_ASSERT_EQUAL_INT(sizeof(options_blob), unicoap_options_size(&options));
     _TEST_ASSERT_EQUAL_BYTES(options_blob, unicoap_options_data(&options), sizeof(options_blob));
 
     uint8_t uint8_val = 42;
     TEST_ASSERT_EQUAL_INT(0, unicoap_options_get_uint8(&options, OPTION_NUMBER, &uint8_val));
-    TEST_ASSERT_EQUAL_INT(0, uint8_val);
+    TEST_ASSERT_EQUAL_INT(OPTION_VALUE, uint8_val);
     uint16_t uint16_val = 42;
     TEST_ASSERT_EQUAL_INT(0, unicoap_options_get_uint16(&options, OPTION_NUMBER, &uint16_val));
-    TEST_ASSERT_EQUAL_INT(0, uint16_val);
+    TEST_ASSERT_EQUAL_INT(OPTION_VALUE, uint16_val);
     uint32_t uint32_val = 42;
     TEST_ASSERT_EQUAL_INT(0, unicoap_options_get_uint32(&options, OPTION_NUMBER, &uint32_val));
-    TEST_ASSERT_EQUAL_INT(0, uint32_val);
+    TEST_ASSERT_EQUAL_INT(OPTION_VALUE, uint32_val);
 }
 
 Test* tests_unicoap_options(void)
@@ -413,7 +414,7 @@ Test* tests_unicoap_options(void)
         new_TestFixture(test_remove_leading),
         new_TestFixture(test_remove_trailing),
         new_TestFixture(test_remove_multiple),
-        new_TestFixture(test_shortest_uint_in_option_value),
+        new_TestFixture(test_option_value_uses_shortest_possible_representation),
     };
 
     EMB_UNIT_TESTCALLER(test_unicoap, NULL, NULL, fixtures);