sys/net/unicoap: properly handle options with value zero#22222
Merged
Conversation
mguetschow
requested review from
carl-tud
and removed request for
Teufelchen1 and
miri64
github-actions
Bot
added
Area: network
mguetschow
added
the
CI: ready for build
Member
|
#22222 🥳 🎈 🎂 |
crasbe
reviewed
Apr 28, 2026
crasbe
added
the
Type: bug
carl-tud
reviewed
May 1, 2026
Contributor
|
lgtm |
mguetschow
force-pushed
the
unicoap-option-value-zero
branch
from
d4948fb to
ba6784c
Compare
Teufelchen1
requested changes
May 4, 2026
Teufelchen1
approved these changes
May 4, 2026
mguetschow
force-pushed
the
unicoap-option-value-zero
branch
from
7b579cc to
6128ad3
Compare
carl-tud
approved these changes
May 4, 2026
Contributor
Author
|
Thanks everyone! 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
CoAP options carrying the value 0 may have been encoded as with value-length zero (this is actually recommended by the RFC).
unicoapwould not have treated such encodings correctly while retrieving the option value.While setting the option,
unicoapalready behaved as recommended.Testing procedure
with an added test case should still pass with this PR (and wouldn't without).
Issues/PRs references
Encountered while working on experimental Uri-Path-Abbrev support based on #21582 in https://github.com/mguetschow/RIOT/tree/unicoap-uri-path-abbrev
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: