boards/waveshare-esp32s3-touch-lcd-128: add board support#22231
boards/waveshare-esp32s3-touch-lcd-128: add board support#22231tuyahia wants to merge 7 commits into
Conversation
tuyahia
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
github-actions
Bot
added
Area: doc
|
@crasbe :D |
crasbe
added
Type: new feature
|
Thank you for porting another board to RIOT. The more the merrier! |
Co-authored-by: Ann🐸 <git@annsann.eu>
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
I think we have to find a different name for the board. Waveshare actually has a lot of round boards based on the ESP32-S3...
Following our general naming convention ( https://github.com/RIOT-OS/RIOT/blob/master/doc/memos/rdm0003.md ) something like waveshare-esp32s3-touch-lcd-128 would be a possibility. Quite a handful, but it would follow their name Waveshare ESP32-S3-Touch-LCD-1.28 while keeping it somewhat consistent with other "ESP32-S3" boards that are abbreviated esp32s3-....
I would not advocate calling it esp32s3-waveshare-touch-lcd-128 to be consistent with the other esp32 boards though.
| @@ -0,0 +1,131 @@ | |||
| <!-- | |||
| SPDX-FileCopyrightText: 2026 Technische Universität Hamburg | |||
There was a problem hiding this comment.
This file looks quite as if it it is based on one of Gunars files too 🤔
There was a problem hiding this comment.
Yes, I followed the structure of Gunar's files for consistency with existing board docs.
Happy to add attribution if that’s expected in this case.
There was a problem hiding this comment.
I can't really tell how much was rewritten and how much was retained 🤷♂️
There was a problem hiding this comment.
Adding it to be safe.
Co-authored-by: crasbe <crasbe@gmail.com>
Good point. I think I will rename it to |
Renamed and tested on the hardware. |
crasbe
changed the title
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
To circumnavigate some potential issues with the upcoming board documentation migration/integration into Starlight in #22257, I added some preventative change comments.
The changes are:
- manually built Table of Contents are not supported anymore
- Manually set section references are not supported anymore
- Images have to use the HTML tag
- Newlines have to be written with
<br>instead of\n - The backticks are preferred over the squiggly line for Code sections
@LasseRosenow did I miss anything?
From my side, that would be the last comments before we can merge this :)
| # SPDX-License-Identifier: LGPL-2.1-only | ||
|
|
||
| config BOARD | ||
| default "waveshare-esp32s3-touch-lcd-128" if BOARD_WAVESHARE_ROUND_ESP32S3 |
There was a problem hiding this comment.
I think the BOARD_WAVESHARE_ROUND_ESP32S3 also has to be changed, doesn't it?
|
@crasbe Thank you for the thorough review and suggestions! |
…g suggestions Co-authored-by: crasbe <crasbe@gmail.com>
Not totally correct. This |
5 participants
Contribution description
This PR adds support for the Waveshare ESP32-S3-Touch-LCD-1.28 board.
Testing procedure
The main features of the board can be tested using the driver tests e.g.
drivers/tests/gc9a01,drivers/tests/qmi8658,drivers/tests/cst816s.Issues/PRs references
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are:
doc.mdwhich was then reviewed and fixed by me.