sys/crypto: improve doxygen markup, add ACCESS() attribute, ...#22380
Open
maribu wants to merge 26 commits into
Open
sys/crypto: improve doxygen markup, add ACCESS() attribute, ...#22380maribu wants to merge 26 commits into
maribu wants to merge 26 commits into
Conversation
maribu
added
the
Type: enhancement
maribu
added
Type: cleanup
github-actions
Bot
added
Area: tests
- clean up and extend the doxygen markup - use `ACCESS()` macro to annotate functions to allow GCC to provide better `-Wstringop-overflow` diagnostics - encode size information into APIs using `uint8_t param[size]` instead of `uint8_t *param` where possible - use idomatic types in API, e.g. consistently `size_t` for size of in-memory structures and `ssize_t` for when that is mixed with in-band error signaling - fix style issues pointed out by the linter
maribu
force-pushed
the
sys/crypto/cleanup
branch
from
June 15, 2026 11:47
3e3402d to
109680b
Compare
crasbe
reviewed
Jun 26, 2026
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: crasbe <crasbe@gmail.com>
Member
|
Whats the state of this PR? I see a lot of commits post review |
maribu
added
the
State: waiting for author
crasbe
added
the
Reviewed: 4-code-style
On legacy ARM and AVR targets, `limits.h` does not define `SSIZE_MAX`. The POSIX standard however requires this. This adds a custom `limits.h` wrapper header that does `#include_next <limits.h>` and then adds an `#define SSIZE_MAX` when it was not provided by the libc.
maribu
removed
the
State: waiting for author
Member
Author
|
Should be good now. Maybe @mguetschow as cryptography expert could take a look as well? |
maribu
added
the
AI: Helped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
ACCESS()macro to annotate functions to allow GCC to provide better-Wstringop-overflowdiagnosticsuint8_t param[size]instead ofuint8_t *paramwhere possiblesize_tfor size of in-memory structures andssize_tfor when that is mixed with in-band error signalingTesting procedure
make -C tests/sys/crypto flash test -j32(Both done by Murdock)
Issues/PRs references
None
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: