Skip to content

Commit dec320f

Browse files
committed
Documentation updates
1 parent b26f2b7 commit dec320f

11 files changed

Lines changed: 63 additions & 27 deletions

File tree

README.md

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,4 @@
22

33
A UVM Agent for the AMBA APB Protocol
44

5-
## Usage
6-
7-
```SystemVerilog
8-
9-
class user_env extends uvm_env;
10-
11-
endclass : user env
12-
13-
```
5+
Documentation can be found: [https://riscy-lib.github.io/apb_agent/](https://riscy-lib.github.io/apb_agent/)

docs/config/Comments.txt

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,23 @@
2222
# ------------------------------------------------------------------------
2323
# The syntax reference is after the definitions.
2424

25+
Alter Comment Type: Class
26+
27+
SystemVerilog Keywords:
28+
package, packages
29+
30+
31+
Comment Type: SVInterface
32+
33+
Display Name: Interface
34+
Plural Display Name: Interfaces
35+
36+
Scope: Start
37+
38+
SystemVerilog Keywords:
39+
svinterface, svinterfaces
40+
41+
2542
Comment Type: Signals
2643

2744
Display Name: Signal

docs/config/Languages.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121

2222
Alter Language: SystemVerilog
2323

24+
Interface Prototype Ender: ;
25+
Property Prototype Ender: ;
2426
Signals Prototype Enders: ; =
2527
Instances Prototype Ender: ;
2628

docs/config/Project.txt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
# Project Information
77
# ------------------------------------------------------------------------
88

9-
Title: PADC Common Cells
10-
Subtitle: A collection of technology agnostic cells and common IP
9+
Title: RISCY-Lib APB Agent
10+
Subtitle: A UVM APB Agent which supports Completers and Requesters
1111

12-
Copyright: © 2025 Texas Instruments, Inc
12+
Copyright: © 2025 RISCY-Lib Contributors
1313

1414

1515
# This is where you put general information about your project. None of these
@@ -74,6 +74,9 @@ Copyright: © 2025 Texas Instruments, Inc
7474
Source Folder: ../../src
7575
Name: source
7676

77+
Source Folder 2: ../../include
78+
Name: include
79+
7780

7881
# This is where you tell Natural Docs which folders it should scan for source
7982
# files. If you add any on the command line this section is ignored except

include/apb_agent_macros.svh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
`ifndef __APB_AGENT_MACROS__SVH__
2020
`define __APB_AGENT_MACROS__SVH__
2121

22+
// Macro: _APB_AGENT_PARAM_DEFS
23+
// Macro for instantiating the common parameters used around the agent
2224
`define _APB_AGENT_PARAM_DEFS \
2325
parameter int ADDR_WIDTH = 32, \
2426
parameter int DATA_WIDTH = 32

src/agent/apb_agent_config.svh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class apb_agent_config extends uvm_object;
4141

4242
// Reference: vif_handle
4343
// The uvm_config_db 'field_name' handle to the virtual interface
44-
string vif_handle="m_vif";
44+
string vif_handle = "m_vif";
4545

4646
// Group: Constructors
4747
////////////////////////////////////////////////////////////////////////////////////////////////

src/agent/apb_driver.svh

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class apb_driver#(`_APB_AGENT_PARAM_DEFS) extends uvm_driver#(apb_transaction#(`
8585
super.run_phase(phase);
8686

8787
if (m_cfg.agent_mode == APB_COMPLETER_AGENT) begin
88-
completer_run_phase(phase);
88+
completer_run_phase();
8989
end
9090
// else if (m_cfg.agent_mode == APB_REQUESTER_AGENT) begin
9191
// requester_run_phase(phase);
@@ -103,7 +103,7 @@ class apb_driver#(`_APB_AGENT_PARAM_DEFS) extends uvm_driver#(apb_transaction#(`
103103

104104
// Task: completer_run_phase
105105
// The UVM Run-Phase for a completer agent
106-
virtual task completer_run_phase(uvm_phase phase);
106+
virtual task completer_run_phase();
107107
apb_transaction#(`_APB_AGENT_PARAM_MAP) trans; // The transaction in the address phase
108108
apb_phase_e phase;
109109

@@ -113,8 +113,8 @@ class apb_driver#(`_APB_AGENT_PARAM_DEFS) extends uvm_driver#(apb_transaction#(`
113113
m_vif.paddr = '0;
114114
m_vif.pprot = '0;
115115
m_vif.pwdata = '0;
116-
m_vif.pstrb = '1;
117-
m_vif.write = 1'b0;
116+
m_vif.pstrb = '1;
117+
m_vif.pwrite = APB_READ;
118118

119119
m_vif.psel = 1'b0;
120120
m_vif.penable = 1'b0;
@@ -135,15 +135,12 @@ class apb_driver#(`_APB_AGENT_PARAM_DEFS) extends uvm_driver#(apb_transaction#(`
135135
m_vif.psel = 1'b1;
136136
m_vif.paddr = trans.addr;
137137
m_vif.pprot = trans.pprot;
138+
m_vif.pwrite = trans.write;
138139

139140
if (trans.write == APB_WRITE) begin
140-
m_vif.write = 1'b1;
141141
m_vif.pwdata = trans.data;
142142
m_vif.pstrb = trans.wstrb;
143143
end
144-
else begin
145-
m_vif.write = 1'b0;
146-
end
147144

148145
phase = APB_ACCESS_PHASE;
149146
end

src/agent/apb_monitor.svh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class apb_monitor#(`_APB_AGENT_PARAM_DEFS) extends uvm_monitor;
9696
forever begin
9797
@(posedge m_vif.pclk);
9898

99-
if (!m_vif.hreset_n) begin
99+
if (!m_vif.preset_n) begin
100100
trans = null;
101101
continue;
102102
end

src/apb_agent_pkg.sv

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
************************************************************************************/
1818

1919
// Package: apb_agent_pkg
20+
// Package which contains the apb_agent an relevant definitions
2021
package apb_agent_pkg;
2122

2223
// UVM Imports

src/apb_definitions.svh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ typedef enum {
2222
APB_REQUESTER_AGENT
2323
} apb_agent_mode_e;
2424

25-
// Struct: apb_pprot_t
25+
// Struct: apb_agent_pkg.apb_pprot_t
2626
typedef struct packed {
2727
logic privileged;
2828
logic insecure;

0 commit comments

Comments
 (0)