Feature/directed graph#9
Merged
Merged
Conversation
resolve() previously returned a plain dict, discarding the dependency graph that resolvelib computed. Callers like _create_library_filelist() had to rebuild the graph by re-reading manifests from disk. ResolveResult now wraps the mapping with a graph (dict[str, set[str]]) and the set of direct dependencies, while providing dict-like convenience methods for backward compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move topological sort logic into ResolveResult so users can get dependency-ordered package names directly. Remove the private _topological_sort from install.py in favor of the new public method. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add 14 tests covering the dict-like interface and topological ordering. The tests caught a bug in topological_order() which was producing dependents-first instead of dependencies-first order. Fixed by reversing the traversal direction in Kahn's algorithm. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the output of the resolution algorithm to a directed graph which enables dependency order tracking.