Conversation
AarC10
commented
Jun 13, 2026
AarC10
commented
Member
- lora.c link-change unpack zeroed 3 of 4 frequency bytes, tuning the radio to garbage on any over-the-air parameter change
- radio_node linkTestChanceExpired killed the interrupt thread (copy-paste from signalStopping), permanently deafening the radio
- boost detection result was never consumed: Preboost now actually enters Flight, and the threshold accounts for the 1 g rest reading
- crashout_stm used uninitialized SPI speed for every transfer and read past the 8-byte transfer in getServoMotion
- stm_bridge actions could hang forever if the STM stopped answering; divide-by-zero NaN cast on the pre-IMU status ticks
- ImageTaker could spin forever on a wedged camera and crash on radio-supplied crop rects; mmap checked NULL instead of MAP_FAILED
- captain/stm_bridge/radio CMakeLists installed nonexistent config dirs so colcon build failed at install for all three packages
- ros2 bag record got '--compression-mode file' as one argument
- start_flight.py had four separate crash-on-start bugs
Highlights (full list in FABLE_BUGFIXES.md): - lora.c link-change unpack zeroed 3 of 4 frequency bytes, tuning the radio to garbage on any over-the-air parameter change - radio_node linkTestChanceExpired killed the interrupt thread (copy-paste from signalStopping), permanently deafening the radio - boost detection result was never consumed: Preboost now actually enters Flight, and the threshold accounts for the 1 g rest reading - crashout_stm used uninitialized SPI speed for every transfer and read past the 8-byte transfer in getServoMotion - stm_bridge actions could hang forever if the STM stopped answering; divide-by-zero NaN cast on the pre-IMU status ticks - ImageTaker could spin forever on a wedged camera and crash on radio-supplied crop rects; mmap checked NULL instead of MAP_FAILED - captain/stm_bridge/radio CMakeLists installed nonexistent config dirs so colcon build failed at install for all three packages - ros2 bag record got '--compression-mode file' as one argument - start_flight.py had four separate crash-on-start bugs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.