Bump 2.2.5#401
Conversation
Signed-off-by: ijnek <kenjibrameld@gmail.com>
use modern cmake to do target-based installation
Signed-off-by: Wonho Yun <ywh@robotis.com>
Signed-off-by: Wonho Yun <ywh@robotis.com>
Deprecate ament_include_dependency usage in CMakeLists.txt
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @robotpilot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello! Gemini here, providing a summary of this pull request. This PR primarily focuses on bumping the version of the dynamixel_workbench and dynamixel_workbench_toolbox packages to 2.2.5. Alongside the version update, it includes significant cleanup of the build system configuration (CMakeLists.txt and package.xml) for the dynamixel_workbench_toolbox package. Specifically, it removes an unused dependency on rclcpp and updates the CMake build commands to use standard CMake functions (target_include_directories, target_link_libraries, install, ament_export_targets) instead of the deprecated ament_target_dependencies and related ament_export_* macros, which is a common practice for modernizing ROS 2 packages, especially in newer distributions like Kilted.
Highlights
- Version Bump: The version of both
dynamixel_workbenchanddynamixel_workbench_toolboxpackages has been updated from2.2.4to2.2.5. - Dependency Removal: An unused dependency on
rclcpphas been removed from thedynamixel_workbench_toolboxpackage'sCMakeLists.txtandpackage.xml. - Build System Modernization: The
CMakeLists.txtfordynamixel_workbench_toolboxhas been refactored to replace deprecatedament_target_dependenciesandament_export_*macros with standard CMake commands (target_include_directories,target_link_libraries,install,ament_export_targets) for better compatibility and adherence to modern CMake practices, particularly relevant for ROS 2 distributions like Kilted. - Changelog Updates: Changelog files (
CHANGELOG.rst) for both packages have been updated to include the changes for version 2.2.5 and fix a typo ('Contributoers' to 'Contributors') in previous entries. - Maintainer Update: The maintainer listed in
dynamixel_workbench_toolbox/library.propertieshas been updated.
Changelog
Click here to see the changelog
- dynamixel_workbench/CHANGELOG.rst
- Added entry for version 2.2.5, noting the removal of unused rclcpp dependency and deprecated ament_target_dependencies.
- Corrected typo 'Contributoers' to 'Contributors' in previous entries.
- dynamixel_workbench/package.xml
- Updated package version to 2.2.5.
- dynamixel_workbench_toolbox/CHANGELOG.rst
- Added entry for version 2.2.5, noting the removal of unused rclcpp dependency and deprecated ament_target_dependencies.
- Corrected typo 'Contributoers' to 'Contributors' in previous entries.
- dynamixel_workbench_toolbox/CMakeLists.txt
- Removed
find_package(rclcpp)(line 26). - Removed unused
include_directoriesandset(dependencies_lib)(lines 35-42). - Replaced
ament_target_dependencieswithtarget_include_directoriesandtarget_link_librariesfor managing dependencies and includes (lines 52-53 replaced by 43-51). - Updated install destination for include directories to include the project name (line 64).
- Removed deprecated
ament_export_include_directories,ament_export_dependencies(rclcpp), andament_export_libraries(lines 74, 76, 77). - Added
ament_export_targetsfor exporting the library target (line 75).
- Removed
- dynamixel_workbench_toolbox/library.properties
- Updated version to 2.2.5.
- Updated maintainer information.
- dynamixel_workbench_toolbox/package.xml
- Updated package version to 2.2.5.
- Removed unused
rclcppdependency from<depend>tags (line 24).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Version bumped, clean the build,
Dependencies now distilled.
CMake commands refined,
Future reviewers will find,
A codebase neatly tilled.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request primarily bumps the version to 2.2.5 and includes significant improvements to the CMake configuration for the dynamixel_workbench_toolbox package. The changes modernize the build process, remove an unused rclcpp dependency, and ensure consistency across package files. Overall, the updates are well-executed and enhance the maintainability and correctness of the build system. Great job on these modernizations!
Summary of Findings
- CMake Modernization: The
dynamixel_workbench_toolbox/CMakeLists.txthas been substantially updated to use modern CMake practices. This includes replacinginclude_directories(),ament_target_dependencies(),ament_export_include_directories(), andament_export_libraries()withtarget_include_directories(),target_link_libraries(), andament_export_targets(). This is a significant improvement for build correctness and maintainability within the ROS 2 ecosystem. - Dependency Cleanup: The unused
rclcppdependency has been correctly removed fromdynamixel_workbench_toolbox. This change is consistently reflected in itsCMakeLists.txt,package.xml, and documented in theCHANGELOG.rst. - Header Installation Path: The installation path for headers in
dynamixel_workbench_toolboxhas been updated toinclude/${PROJECT_NAME}. This namespacing is a ROS 2 best practice and is correctly paired with the$<INSTALL_INTERFACE:include/${PROJECT_NAME}>generator expression intarget_include_directories. - Consistent Versioning and Changelog: Version numbers have been consistently updated to 2.2.5 across all relevant files (
CHANGELOG.rst,package.xml,library.properties). The changelogs are clear and accurately reflect the modifications. Typo corrections in previous changelog entries were also included, which is a nice touch.
Merge Readiness
The changes in this pull request are well-implemented and improve the quality of the codebase, particularly the CMake updates. From my review, I see no critical or high-severity issues. The code appears to be in good shape for merging. As always, ensure any CI checks pass and consider additional reviews if required by your team's policies. I am not authorized to approve pull requests.
3 participants
No description provided.