Skip to content

Add ament_cmake buildtool_depend tag in metapackage#94

Merged
GyuH13 merged 1 commit into
mainfrom
feature-fix-metapackage
Jan 23, 2026
Merged

Add ament_cmake buildtool_depend tag in metapackage#94
GyuH13 merged 1 commit into
mainfrom
feature-fix-metapackage

Conversation

@GyuH13
Copy link
Copy Markdown
Member

@GyuH13 GyuH13 commented Jan 19, 2026

  • Add ament_cmake buildtool_depend tag in metapackage for fixing bloom CI build error.

…ing; update changelogs and add ament_cmake as a build dependency.
Copilot AI review requested due to automatic review settings January 19, 2026 01:50
@GyuH13 GyuH13 self-assigned this Jan 19, 2026
@GyuH13 GyuH13 requested a review from yun-goon January 19, 2026 01:50
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build issue in the Bloom CI pipeline by introducing a missing build dependency. The ament_cmake build tool dependency has been explicitly added to the turtlebot3_machine_learning metapackage, ensuring that the package can be correctly built and released. This change also includes routine version bumps and changelog updates across the affected packages.

Highlights

  • Build Dependency Fix: Added ament_cmake as a buildtool_depend to the turtlebot3_machine_learning metapackage to resolve Bloom CI build errors.
  • Version Update: Incremented the version number for turtlebot3_dqn and turtlebot3_machine_learning packages from 1.0.2 to 1.0.3.
  • Changelog Updates: Updated CHANGELOG.rst files for both turtlebot3_dqn and turtlebot3_machine_learning to reflect the new version and the added build dependency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds ament_cmake as a buildtool_depend to the turtlebot3_machine_learning metapackage to resolve a CI build error. The package versions are consistently updated. I have a couple of minor suggestions to improve the clarity and consistency of the changelog entries.

Comment thread turtlebot3_dqn/CHANGELOG.rst
Comment thread turtlebot3_machine_learning/CHANGELOG.rst
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the missing ament_cmake buildtool dependency to the turtlebot3_machine_learning metapackage to resolve bloom CI build errors. The change ensures that the build system correctly declares its dependency on ament_cmake, which is required by the package's CMakeLists.txt file.

Changes:

  • Added buildtool_depend tag for ament_cmake in the metapackage's package.xml
  • Updated version numbers from 1.0.2 to 1.0.3 across both packages
  • Added changelog entries documenting the buildtool_depend addition

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
turtlebot3_machine_learning/package.xml Added missing ament_cmake buildtool_depend tag and bumped version to 1.0.3
turtlebot3_machine_learning/CHANGELOG.rst Added changelog entry for version 1.0.3 documenting the buildtool_depend addition
turtlebot3_dqn/setup.py Bumped version to 1.0.3 for consistency with metapackage
turtlebot3_dqn/package.xml Bumped version to 1.0.3 for consistency with metapackage
turtlebot3_dqn/CHANGELOG.rst Added changelog entry for version 1.0.3 with no functional changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GyuH13 GyuH13 requested a review from nhw-robotis January 23, 2026 01:54
@GyuH13 GyuH13 merged commit 3bce927 into main Jan 23, 2026
13 checks passed
@GyuH13 GyuH13 deleted the feature-fix-metapackage branch January 23, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants