Fix deprecated hardware_interface API#91
Fix deprecated hardware_interface API#91christophfroehlich wants to merge 1 commit intoROBOTIS-GIT:mainfrom
Conversation
Summary of ChangesHello @christophfroehlich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the hardware interface to use the new HardwareComponentInterfaceParams in the on_init method, addressing the deprecated API from ros2_control. The changes in both the header and the implementation file are consistent and correctly applied. The updated call to the base class on_init method is also correct. Overall, this is a clean and necessary update to maintain compatibility.
See ros-controls/ros2_control#2323
needed for ros-controls/ros2_control#2589
Please release it to kilted and rolling, thanks :)
Note: This API is not available on humble.