Open
Conversation
Signed-off-by: Fujun Han <fujun.han@iluvatar.com>
Signed-off-by: Fujun Han <fujun.han@iluvatar.com>
Contributor
Author
|
Could @coderfeli please take a look at this PR? This fixes a generic fly-opt registration gap exposed by gpu-module-to-binary, and I would appreciate a review on whether this is the right place to register the GPU-to-LLVMIR translations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fly-optregression smoke test that exercises the realgpu-module-to-binarypath on a minimalgpu.module.fly-opt, matching the requirements of MLIR GPU binary serialization.MLIRToLLVMIRTranslationRegistrationso the translation registration symbols are available.Motivation
fly-optcurrently registers MLIR dialects, extensions, and passes, but not the GPU-to-LLVMIR translation interfaces required bygpu-module-to-binary.As a result, running binary codegen through
fly-optcan fail before target serialization with:Test Plan
1 passed
When no fly-opt binary is available, the test skips unless FLYDSL_FLY_OPT or FLY_OPT points to a built binary.