runtime: hard-fail mgpuModuleLoadJIT on HIP#748
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
8c0c6b9 to
3faf638
Compare
3faf638 to
38a0b2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mgpuModuleLoadJITin the ROCm runtime wrappers previously usedassert(false)and then returnednullptron HIP builds.In release builds (
NDEBUG), that assertion is stripped, so callers could continue with a null module pointer and fail later in opaque ways.This change makes the function fail fast in all configurations by:
stderr.std::abort()unconditionally inmgpuModuleLoadJIT.Behavior impact
nullptr.Validation
Files
lib/Runtime/ROCm/FlyRocmRuntimeWrappers.cpp