Skip to content

[HIPIFY][ROCM-1254] Add cooperative_groups reduce and scans support #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
g-h-c wants to merge 2 commits into
base: amd-develop
Choose a base branch
from
Open

[HIPIFY][ROCM-1254] Add cooperative_groups reduce and scans support #2448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a43b62b
ROCM-1254 - add cooperative_groups::reduce() support
g-h-c Mar 25, 2026
439ed88
AIRUNTIME-171 - add cooperative_groups::inclusive_scan() and exclusiv…
g-h-c Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bin/hipify-perl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9920,6 +9920,8 @@ sub simpleMappings {
sub simpleIncludes {
subst("channel_descriptor.h", "hip\/channel_descriptor.h", "include");
subst("cooperative_groups.h", "hip\/hip_cooperative_groups.h", "include");
subst("cooperative_groups\/reduce.h", "hip\/cooperative_groups\/hip_reduce.h", "include");
subst("cooperative_groups\/scan.h", "hip\/cooperative_groups\/hip_scan.h", "include");

@ranapratap55 ranapratap55 Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    subst("cooperative_groups\/scan.h", "hip\/cooperative_groups\/hip_scan.h", "include");

This looks like hand edited. After fixing the C++ typo, please regenerate this file.

subst("cuComplex.h", "hip\/hip_complex.h", "include_cuda_main_header");
subst("cub\/cub.cuh", "hipcub\/hipcub.hpp", "include_cuda_main_header");
subst("cublas.h", "hipblas.h", "include_cuda_main_header");
Expand Down
2 changes: 2 additions & 0 deletions src/CUDA2HIP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ const std::map <llvm::StringRef, hipCounter> CUDA_INCLUDE_MAP {
{"vector_types.h", {"hip/hip_vector_types.h", "", CONV_INCLUDE, API_RUNTIME, 0}},
{"cuda_profiler_api.h", {"hip/hip_runtime_api.h", "", CONV_INCLUDE, API_RUNTIME, 0}},
{"cooperative_groups.h", {"hip/hip_cooperative_groups.h", "", CONV_INCLUDE, API_RUNTIME, 0}},
{"cooperative_groups/reduce.h", {"hip/cooperative_groups/hip_reduce.h", "", CONV_INCLUDE, API_RUNTIME, 0}},
{"cooperative_groups/scan.h", {"hip/cooperative_groups/hip_scah", "", CONV_INCLUDE, API_RUNTIME, 0}},

@ranapratap55 ranapratap55 Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"cooperative_groups/scan.h", {"hip/cooperative_groups/hip_scah", "", CONV_INCLUDE, API_RUNTIME, 0}},
{"cooperative_groups/scan.h", {"hip/cooperative_groups/hip_scan.h", "", CONV_INCLUDE, API_RUNTIME, 0}},

Please fix the typo.

{"library_types.h", {"hip/library_types.h", "", CONV_INCLUDE, API_RUNTIME, 0}},
{"math_constants.h", {"hip/hip_math_constants.h", "", CONV_INCLUDE, API_RUNTIME, 0}},
// cuda-samples helper includes
Expand Down
Loading