Skip to content

Commit f952643

Browse files
Add TODOs for gfx950 nightly and dependency version tracking
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent b426de0 commit f952643

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

build_tools/github_actions/test_executable_scripts/test_tensilelite.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@
107107
)
108108

109109
# TensileLite Python unit tests (includes GPU subtile tests).
110+
# TODO(TheRock#3288): gfx950-dcgpu is excluded from PR CI (ci.yml) due to runner
111+
# capacity — GPU subtile tests only exercise on nightly/scheduled builds.
110112
logging.info("=== Running TensileLite unit tests ===")
111113
subprocess.check_call(
112114
[

build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,9 @@ def testSharedLibrariesLoad(self):
6767
continue
6868

6969
if so_path.name.endswith(".abi3.so") or ".cpython-" in so_path.name:
70-
# Python C extensions must be loaded via importlib, not
71-
# ctypes.CDLL. Stable ABI extensions (.abi3.so) target a
72-
# minimum CPython version and may use symbols absent from
73-
# older interpreters (e.g. PyType_FromMetaclass requires
74-
# 3.12+). Version-tagged extensions (.cpython-3XX) are
75-
# similarly incompatible across interpreter versions.
70+
# Python C extensions use symbols resolved at import time,
71+
# not via dlopen — ctypes.CDLL fails across interpreter
72+
# versions (e.g. .abi3.so using PyType_FromMetaclass on <3.12).
7673
continue
7774

7875
extra_setup = ""

requirements-test.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ packaging==25.0
1414
python-magic==0.4.27; sys_platform != "win32"
1515

1616
# tensilelite/rocisa test requirements
17+
# TODO: Keep in sync with rocm-libraries/projects/hipblaslt/tensilelite/requirements.txt
1718
msgpack>=1.0.0
1819
joblib>=1.4.0
1920
numpy>=1.26.0

0 commit comments

Comments
 (0)