Make CI release type explicit and limit workflow_dispatch inputs to [ci, dev]#5481
Open
ScottTodd wants to merge 3 commits into
Open
Make CI release type explicit and limit workflow_dispatch inputs to [ci, dev]#5481ScottTodd wants to merge 3 commits into
ScottTodd wants to merge 3 commits into
Conversation
1 task
Member
Author
|
Several of the Windows test failures are #5163 (corrupt uv package cache is causing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up to:
This changes the release type used throughout workflows and associated scripts for CI runs (starting from
multi_arch_ci.ymlor equivalent) from using""(empty string) to using"ci".With that in place, it then replaces all uses of the
release_typeinput forworkflow_dispatchevents with achoiceinput type that only allows[dev]or[ci, dev], preventing developers from triggeringnightlyorprereleasebuilds from this repository. All releases with those types should be triggered in https://github.com/ROCm/rockrel instead (where permissions will be more limited).Test Plan
multi_arch_build_tarballs.yml--> https://github.com/ROCm/TheRock/actions/runs/26544216544 --> https://therock-ci-artifacts.s3.amazonaws.com/26544216544-linux/tarballs/index.htmlrelease_portable_linux_packages.ymlSubmission Checklist
Generated with Codex