Add test filter standardisation for hipsolver#5490
Draft
dileepr1 wants to merge 1 commit into
Draft
Conversation
Mirrors PR #5278 for the SOLVER component, paired with the rocm-libraries branch users/dravindr/tf_hipsolver which installs bin/hipsolver/CTestTestfile.cmake via apply_test_category_labels(). - fetch_test_configurations.py: hipsolver test_script -> test_runner.py so the generic runner drives ctest from THEROCK_BIN_DIR/hipsolver using the quick/standard/comprehensive/full category labels. - artifact-blas.toml: include bin/hipsolver/** in the hipSOLVER test component so the install-tree CTestTestfile.cmake is bundled (same pattern as bin/rocblas/**). Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
dileepr1
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
May 28, 2026
Restore all four TheRock-side workflow refs to the develop-tracked pin e44b42bb (2026-05-20): - .github/workflows/therock-ci-linux.yml - .github/workflows/therock-ci-windows.yml - .github/workflows/therock-test-component.yml - .github/workflows/therock-test-packages.yml Reverts the workflow ref changes from 71e281c, 17acb08 and daaa6a4, which temporarily pointed all four files at the paired TheRock branch users/dravindr/tr_hipsolver. At the develop-pinned TheRock SHA, fetch_test_configurations.py still runs the legacy test_hipsolver.py for hipsolver (not test_runner.py), and math-libs/BLAS/artifact-blas.toml does not include bin/hipsolver/**, so the new install-tree CTestTestfile.cmake and apply_test_category_labels() metadata added by this PR remain dormant until ROCm/TheRock#5490 merges and these refs are bumped to a main-tracked SHA that contains it. Until then the hipsolver Linux/Windows test shards behave exactly as on develop. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add test filter standardisation for hipsolver.
This works with the companion PR ROCm/rocm-libraries#7546
Technical Details
test_runner.py so the generic runner drives ctest from
THEROCK_BIN_DIR/hipsolver using the quick/standard/comprehensive/full
category labels.
Test Plan
Confirm that the CI tests for hipsolver works good once ROCm/rocm-libraries#7546 is merged.
Test Result
Submission Checklist