[rocprofiler-systems] Route test job through test_runner.py#5522
Draft
dileepr1 wants to merge 1 commit into
Draft
[rocprofiler-systems] Route test job through test_runner.py#5522dileepr1 wants to merge 1 commit into
dileepr1 wants to merge 1 commit into
Conversation
Switches the `rocprofiler-systems` entry in `fetch_test_configurations.py`
from the bespoke `test_rocprofiler_systems.py` to the shared
`test_runner.py`, completing the test-filter standardisation handoff for
this component (paired with rocm-systems `users/dravindr/tf_rocprofsys`,
which now emits `quick` / `standard` / `comprehensive` / `full` tier
labels and a matching `<tier>_exclude` label via the pytest CTest hook).
Adds a `COMPONENT_OVERRIDES` entry for `rocprofiler-systems` that mirrors
the legacy script's environment:
- test_dir -> `share/rocprofiler-systems/tests` (where the generated
`CTestTestfile.cmake` and the `rocprofsys-tests.pyz` live)
- PATH prepended with `bin` so `rocprof-sys-*` / `rocprofv3` resolve
- LD_LIBRARY_PATH prepended with the examples lib dir
- `ROCPROFSYS_INSTALL_DIR` and `ROCPROFSYS_MAX_THREADS` set explicitly
The literal-value env vars surface a new, generic `env` field on
`COMPONENT_OVERRIDES`. Values are formatted via `str.format()` with a
single `{rocm_path}` placeholder, which keeps the existing path-prepend
mechanism untouched and is purely additive for other components.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The literal-value env vars surface a new, generic
envfield onCOMPONENT_OVERRIDES. Values are formatted viastr.format()with a single{rocm_path}placeholder, which keeps the existing path-prepend mechanism untouched and is purely additive for other components.Motivation
Add test filter standardisation for hipdnn.
This works with the companion PR ROCm/rocm-systems#6461
Technical Details
Switches the
rocprofiler-systemsentry infetch_test_configurations.pyfrom the bespoketest_rocprofiler_systems.pyto the sharedtest_runner.py, completing the test-filter standardisation handoff for this component (paired with rocm-systemsusers/dravindr/tf_rocprofsys, which now emitsquick/standard/comprehensive/fulltier labels and a matching<tier>_excludelabel via the pytest CTest hook).Adds a
COMPONENT_OVERRIDESentry forrocprofiler-systemsthat mirrors the legacy script's environment:share/rocprofiler-systems/tests(where the generatedCTestTestfile.cmakeand therocprofsys-tests.pyzlive)binsorocprof-sys-*/rocprofv3resolveROCPROFSYS_INSTALL_DIRandROCPROFSYS_MAX_THREADSset explicitlyTest Plan
Confirm that rocprofiler-systems tests gets triggered through therock CI once ROCm/rocm-systems#6461 is merged.
Test Result
Submission Checklist