[tensilelite] Re-apply test component config and fix PyTorch SDK test failure#5529
Open
archana-ramalingam wants to merge 3 commits into
Open
[tensilelite] Re-apply test component config and fix PyTorch SDK test failure#5529archana-ramalingam wants to merge 3 commits into
archana-ramalingam wants to merge 3 commits into
Conversation
013446e to
86bab80
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
86bab80 to
f952643
Compare
| python-magic==0.4.27; sys_platform != "win32" | ||
|
|
||
| # tensilelite/rocisa test requirements | ||
| # TODO: Keep in sync with rocm-libraries/projects/hipblaslt/tensilelite/requirements.txt |
Contributor
Author
There was a problem hiding this comment.
@geomin12 What is the recommended way to keep the versions here in sync with parent repo?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-apply tensilelite test component configuration (reverted in #5520) and fix the
testSharedLibrariesLoadfailure on Python 3.10/3.11.Technical details
_rocisa.abi3.so: undefined symbol: PyType_FromMetaclasson Python 3.10/3.11 #5516:_rocisa.abi3.sousesPyType_FromMetaclass(Python 3.12+ symbol).testSharedLibrariesLoadtest loads all.sofiles viactypes.CDLL, which fails for Python C extensions under older interpreters..abi3.soand.cpython-*extensions inlibraries_test.py— these must be loaded viaimportlib, notctypes.CDLL. Same pattern as the existingamd_smi/goamdsmiskip.-DROCISA_USE_STABLE_ABI=ONis preserved — the stable ABI build is correct; the issue was only in how the PyTorch SDK test loads the.so.Test plan
testSharedLibrariesLoadpasses on Python 3.10/3.11 (no longer attempts to ctypes-load_rocisa.abi3.so)test_tensilelite.py(48 passed, 200 GPU-skipped, 1 xfailed)Fixes #5516
AIGECORE-1997