Re-land (#5515) Include ROCm base version in TheRock manifest#5530
Open
erman-gurses wants to merge 1 commit into
Open
Re-land (#5515) Include ROCm base version in TheRock manifest#5530erman-gurses wants to merge 1 commit into
erman-gurses wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland #5515
Reverted at #5527
Include ROCm base version in TheRock manifest
Add an optional
rocm_versionfield to generated manifests byderiving the base semantic version from
rocm_package_version.Examples:
7.14.0a20260526+a0->7.14.0git-> norocm_versionfield emittedThis keeps manifest generation self-contained while providing
normalized version metadata for downstream CI/CD consumers.
Validated:
THEROCK_PACKAGE_VERSION=gitLocal Validation
Validated both manifest generation paths locally:
1. Direct manifest generation
Verified that:
correctly emits:
without generating
rocm_version.Also verified that:
correctly emits:
2. CMake integration path
Validated the actual
therock-aux-overlaymanifest generation path with:cmake -S . -B build-min -GNinja \ -DTHEROCK_PACKAGE_VERSION=git \ -DTHEROCK_AMDGPU_FAMILIES=gfx94X-dcgpu cmake --build build-min --target therock-aux-overlayResult:
TheRock/build-min/base/aux-overlay/build/therock_manifest.jsonand:
cmake -S . -B build-min-version -GNinja \ -DTHEROCK_PACKAGE_VERSION=7.14.0a20260526+a0 \ -DTHEROCK_AMDGPU_FAMILIES=gfx94X-dcgpu cmake --build build-min-version --target therock-aux-overlayResult:
TheRock/build-min-version/base/aux-overlay/build/therock_manifest.jsonBoth builds completed successfully and generated the manifest correctly.
3. CI Result:
https://therock-ci-artifacts.s3.amazonaws.com/26666604312-linux/manifests/therock_manifest.json