Revert "CI: Temporarily use previous vllm nightly image"#3102
Open
gyohuangxin wants to merge 5 commits into
Open
Revert "CI: Temporarily use previous vllm nightly image"#3102gyohuangxin wants to merge 5 commits into
gyohuangxin wants to merge 5 commits into
Conversation
This reverts commit 1318b9c.
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts #3043 by changing the vLLM benchmark workflow’s Docker base image back from a pinned nightly digest to the floating rocm/vllm-dev:nightly tag.
Changes:
- Update
.github/workflows/vllm_benchmark.yamlto userocm/vllm-dev:nightlyinstead of a@sha256:-pinned image digest.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -15,7 +15,7 @@ concurrency: | |||
| env: | |||
| VLLM_BRANCH: "main" | |||
| VLLM_REPOSITORY_URL: "https://github.com/vllm-project/vllm" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3043