Skip to content

Revert "CI: Temporarily use previous vllm nightly image"#3102

Open
gyohuangxin wants to merge 5 commits into
mainfrom
revert-3043-gyohuangxin-patch-15
Open

Revert "CI: Temporarily use previous vllm nightly image"#3102
gyohuangxin wants to merge 5 commits into
mainfrom
revert-3043-gyohuangxin-patch-15

Conversation

@gyohuangxin
Copy link
Copy Markdown
Member

Reverts #3043

@gyohuangxin gyohuangxin requested review from a team and Copilot May 9, 2026 07:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All of the above

Add labels via the sidebar or gh pr edit 3102 --add-label <label>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts #3043 by changing the vLLM benchmark workflow’s Docker base image back from a pinned nightly digest to the floating rocm/vllm-dev:nightly tag.

Changes:

  • Update .github/workflows/vllm_benchmark.yaml to use rocm/vllm-dev:nightly instead of a @sha256:-pinned image digest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -15,7 +15,7 @@ concurrency:
env:
VLLM_BRANCH: "main"
VLLM_REPOSITORY_URL: "https://github.com/vllm-project/vllm"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants