[BugFix] A4W4 FMoE run_config weight shuffle#3110
Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the FMoE tuning run_config path to preshuffle FP4 weights when they are treated as preshuffled (is_shuffled=True), keeping the FP4 weight and scale layouts consistent during tuning comparisons.
Changes:
- Preshuffle
w1_qt_fmoe/w2_qt_fmoewithshuffle_weight(..., (16, 16))in the FP4 fallback branch sois_shuffled=Trueaccurately reflects the tensor layout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2950
to
+2952
| else: | ||
| w1_qt_fmoe = shuffle_weight(w1_qt_fmoe, (16, 16)) | ||
| w2_qt_fmoe = shuffle_weight(w2_qt_fmoe, (16, 16)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix FMoE
run_configto preshuffle FP4 weights when marking them as shuffled, keepingweightandscalelayouts consistent during tuning compare.Technical Details
Test Plan
Test Result
Submission Checklist