Conversation
Signed-off-by: fsx950223 <fsx950223@outlook.com> Made-with: Cursor
Signed-off-by: fsx950223 <fsx950223@outlook.com> Made-with: Cursor
Signed-off-by: fsx950223 <fsx950223@outlook.com> Made-with: Cursor
Signed-off-by: fsx950223 <fsx950223@outlook.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Gluon-based paged-attention decode implementation, including AOT compilation metadata and PS (partitioned softmax) reduction paths, to better support FP8 workflows and configurable output/temporary dtypes.
Changes:
- Add
OUTPUT_DTYPEconstexpr plumbed through Gluon decode kernels and the wrapper, and adjust temporary output dtype defaults for FP8 queries. - Update PS reduce FlyDSL kernel codegen to newer FlyDSL APIs (
fx.*,const_expr) and adjust reduction fallback ordering. - Extend Gluon AOT compile signature/function-keying to include output and temporary output dtypes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| op_tests/triton_tests/test_pa_decode_gluon.py | Runs more local test entrypoints when invoked as a script (__main__). |
| csrc/cpp_itfs/pa_gluon_aot/pa_decode_gluon_aot.py | Adds output/temporary dtype specialization to AOT compile signature and naming. |
| aiter/ops/triton/gluon/pa_decode_gluon.py | Adds OUTPUT_DTYPE to kernels/wrappers, updates FP8 query handling, and refactors PS reduce fallback logic/FlyDSL kernel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
5125
to
+5152
| @@ -5166,8 +5146,34 @@ def _paged_attention_decode_v2_reduce_kernel_wrapper( | |||
| head_size=head_size, | |||
| context_partition_num=context_partition_num, | |||
| ) | |||
| return | |||
| except ImportError: | |||
| except Exception: | |||
| pass | |||
| try: | |||
| if CXX_PS_REDUCE_AVAILABLE: | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist