[Bugfix][Build] Grouped MoE build should respect GPU_ARCHS#4072
Open
simondanielsson wants to merge 3 commits into
Open
[Bugfix][Build] Grouped MoE build should respect GPU_ARCHS#4072simondanielsson wants to merge 3 commits into
simondanielsson wants to merge 3 commits into
Conversation
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
…ld-guard Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4071.
FlyDSL Grouped MoE kernel (gfx1250 only) was always built, irrespective of
GPU_ARCHS. This slows down build time for say gfx950-only builds.Technical Details
Don't build kernels whose gfx column in the csv is not part of GPU_ARCHS. When GPU_ARCHS is not set, we always build the kernels (as expected).
At the moment all rows in the csv have gfx1250 so technically we could skip parsing the entire file if GPU_ARCHS is not gfx1250, but to avoid future bugs we make a decision based on the gfx value in every row.
Test Plan
Build AITER for say gfx950 on this branch and main. Measure build time.
Test Result
Submission Checklist