Skip to content

condense comments#4079

Open
JaxChen29 wants to merge 2 commits into
ROCm:mainfrom
JaxChen29:condense_comment_0704
Open

condense comments#4079
JaxChen29 wants to merge 2 commits into
ROCm:mainfrom
JaxChen29:condense_comment_0704

Conversation

@JaxChen29

@JaxChen29 JaxChen29 commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Motivation

supplementary pr for #4036

Technical Details

remove unnecessary namespace and comments

Test Plan

opus test in test_mha.py

Test Result

all passed

Submission Checklist

@JaxChen29 JaxChen29 requested a review from a team July 4, 2026 10:53
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 4079 --add-label <label>

@zufayu zufayu requested a review from valarLip July 6, 2026 02:01
@JaxChen29 JaxChen29 force-pushed the condense_comment_0704 branch from 2fbb48d to cc7cab7 Compare July 6, 2026 04:48
@JaxChen29 JaxChen29 requested a review from carlushuang July 6, 2026 07:09

@carlushuang carlushuang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants