Skip to content

Commit 14c49d8

Browse files
committed
compile time fix for gfx1201
1 parent 1190efe commit 14c49d8

2 files changed

Lines changed: 19 additions & 12 deletions

File tree

include/ck_tile/ops/gemm_quant/pipeline/gemm_quant_pipeline_problem.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,8 @@ struct GemmQuantPipelineProblemBase : public GemmPipelineProblemBase<ADataType_,
7979
static constexpr auto TailNum = TailNum_;
8080

8181
static_assert(BlockGemmShape::kM % AQuantGroupSize::kM == 0);
82-
static_assert(BlockGemmShape::kN % AQuantGroupSize::kN == 0);
8382
static_assert(BlockGemmShape::kK % AQuantGroupSize::kK == 0);
8483
static_assert(BlockGemmShape::kM % BQuantGroupSize::kM == 0);
85-
static_assert(BlockGemmShape::kN % BQuantGroupSize::kN == 0);
8684
static_assert(BlockGemmShape::kK % BQuantGroupSize::kK == 0);
8785

8886
[[nodiscard]] CK_TILE_HOST static const std::string GetName()

include/ck_tile/ops/gemm_quant/pipeline/gemm_wp_bquant_pipeline_ag_bg_cr_v2.hpp

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -144,23 +144,32 @@ struct WPQuantBPipelineAgBgCrV2 : public WeightPreshufflePipelineAGmemBGmemCRegV
144144
// Insert LDS read/write groups periodically based on ds_rep.
145145
// The % pattern staggers READ and WRITE so they don't collapse
146146
// into the same cycle in the model.
147-
if constexpr(ds_rep > 0 && i_inst % ds_rep == 0)
147+
if constexpr(ds_rep > 0)
148148
{
149-
__builtin_amdgcn_sched_group_barrier(
150-
LLVMSchedGroupMask::DS_READ, 1, 0); // DS read
149+
if( i_inst % ds_rep == 0)
150+
{
151+
__builtin_amdgcn_sched_group_barrier(
152+
LLVMSchedGroupMask::DS_READ, 1, 0); // DS read
153+
}
151154
}
152-
if constexpr(ds_rep > 0 && i_inst % ds_rep == 1)
155+
if constexpr(ds_rep > 0)
153156
{
154-
__builtin_amdgcn_sched_group_barrier(
155-
LLVMSchedGroupMask::DS_WRITE, 1, 0); // DS write
157+
if(i_inst % ds_rep == 1)
158+
{
159+
__builtin_amdgcn_sched_group_barrier(
160+
LLVMSchedGroupMask::DS_WRITE, 1, 0); // DS write
161+
}
156162
}
157163

158-
if constexpr(buffer_load_rep > 0 && i_inst % buffer_load_rep == 0)
164+
if constexpr(buffer_load_rep > 0)
159165
{
160-
if constexpr(ds_write_inst > 0)
166+
if(i_inst % buffer_load_rep == 0)
161167
{
162-
__builtin_amdgcn_sched_group_barrier(
163-
LLVMSchedGroupMask::VMEM_READ, 1, 0); // VMEM read
168+
if constexpr(ds_write_inst > 0)
169+
{
170+
__builtin_amdgcn_sched_group_barrier(
171+
LLVMSchedGroupMask::VMEM_READ, 1, 0); // VMEM read
172+
}
164173
}
165174
}
166175
// Always mark some VALU work in the loop to reflect auxiliary scalar

0 commit comments

Comments
 (0)