Skip to content

Commit b05040b

Browse files
illsilinassistant-librarian[bot]
illsilin
authored and
assistant-librarian[bot]
committed
[rocm-libraries] ROCm/rocm-libraries#7111 (commit 651947f)
[CK] Fix latest batch of staging compiler warnings ## Motivation Suppress the new batch of clang lifetimebound and invalidation warnings with the latest staging compiler. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
1 parent 41064d8 commit b05040b

37 files changed

Lines changed: 117 additions & 11 deletions

File tree

‎Jenkinsfile‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2119,9 +2119,11 @@ pipeline {
21192119
}
21202120
success {
21212121
script {
2122-
// Report the parent stage build ck and run tests status
2123-
setGithubStatus("${env.STAGE_NAME}", 'success', "Stage ${env.STAGE_NAME} passed")
2124-
echo "Reporting success status for build ck and run tests"
2122+
node(rocmnode("nogpu")) {
2123+
// Report the parent stage build ck and run tests status
2124+
setGithubStatus("${env.STAGE_NAME}", 'success', "Stage ${env.STAGE_NAME} passed")
2125+
echo "Reporting success status for build ck and run tests"
2126+
}
21252127
}
21262128
}
21272129
}
@@ -2145,9 +2147,11 @@ pipeline {
21452147
post {
21462148
success {
21472149
script {
2148-
// Report the skipped parent's stage status
2149-
setGithubStatus("${env.STAGE_NAME}", 'success', "Stage ${env.STAGE_NAME} passed")
2150-
echo "Process Performance Test Results stage skipped."
2150+
node(rocmnode("nogpu")) {
2151+
// Report the skipped parent's stage status
2152+
setGithubStatus("${env.STAGE_NAME}", 'success', "Stage ${env.STAGE_NAME} passed")
2153+
echo "Process Performance Test Results stage skipped."
2154+
}
21512155
}
21522156
}
21532157
}

‎cmake/gtest.cmake‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,16 @@ set(GTEST_CXX_FLAGS
7171
-Wno-lifetime-safety-intra-tu-suggestions
7272
-Wno-lifetime-safety-cross-tu-suggestions
7373
-Wno-character-conversion
74+
-Wno-lifetime-safety-invalidation
7475
)
7576

7677
if(WIN32)
7778
list(APPEND GTEST_CXX_FLAGS
7879
-Wno-suggest-destructor-override
7980
-Wno-suggest-override
8081
-Wno-nonportable-system-include-path
81-
-Wno-language-extension-token)
82+
-Wno-language-extension-token
83+
-Wno-lifetime-safety-invalidation)
8284
endif()
8385

8486
target_compile_options(gtest PRIVATE ${GTEST_CXX_FLAGS})

‎example/40_conv2d_fwd_quantization/run_conv2d_fwd_perlayer_quantization_example.inc‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,7 @@ bool run_grouped_conv_fwd(bool do_verification,
132132

133133
ref_invoker.Run(ref_argument);
134134

135-
out_host.ForEach([&](auto&, auto idx)
136-
{
137-
out_element_op(out_host(idx), c_host(idx));
138-
});
135+
out_host.ForEach([&](auto&, auto idx) { out_element_op(out_host(idx), c_host(idx)); });
139136

140137
out_device_buf.FromDevice(out_device.mData.data());
141138

‎example/ck_tile/01_fmha/fmha_fwd_head_grouping.hpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
#define CK_TILE_FMHA_ENABLE_HEAD_GROUPING 1
2323
#endif
2424

25+
#pragma clang diagnostic push
26+
#pragma clang diagnostic ignored "-Wlifetime-safety-intra-tu-suggestions"
2527
#if CK_TILE_FMHA_ENABLE_HEAD_GROUPING
2628
CK_TILE_DECLARE_ENV_VAR_BOOL(CK_TILE_FMHA_HEAD_GROUP_LOG)
2729
CK_TILE_DECLARE_ENV_VAR_BOOL(CK_TILE_FMHA_DISABLE_HEAD_GROUPING)
@@ -427,3 +429,4 @@ float run_fwd_head_grouped(const ck_tile::stream_config& sc,
427429

428430
} // namespace fmha_fwd_head_grouping
429431
#endif // CK_TILE_FMHA_ENABLE_HEAD_GROUPING
432+
#pragma clang diagnostic pop

‎example/ck_tile/01_fmha/fmha_fwd_runner.hpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
#error "we should enable fmha_fwd_splitkv() api in order to cooperate with fmha_fwd_appendkv()"
2828
#endif
2929

30+
#pragma clang diagnostic push
31+
#pragma clang diagnostic ignored "-Wlifetime-safety-invalidation"
3032
enum class fwd_result
3133
{
3234
success,
@@ -2484,3 +2486,4 @@ fwd_result fmha_fwd_run(mode_enum mode,
24842486

24852487
return pass ? fwd_result::success : fwd_result::failure;
24862488
}
2489+
#pragma clang diagnostic pop

‎example/ck_tile/20_grouped_convolution/grouped_convolution_utils.hpp‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
#include "ck_tile/ops/elementwise/unary_element_wise_operation.hpp"
1616
#include "conv_configs.hpp"
1717

18+
#pragma clang diagnostic push
19+
#pragma clang diagnostic ignored "-Wlifetime-safety-invalidation"
20+
1821
template <typename InDataType, typename WeiDataType, typename AccDataType, typename OutDataType>
1922
auto calculate_rtol_atol(const ck_tile::index_t GemmK,
2023
const ck_tile::index_t kbatch,
@@ -144,3 +147,4 @@ struct InvokerResult
144147
float ave_time;
145148
ck_tile::index_t split_k;
146149
};
150+
#pragma clang diagnostic pop

‎include/ck/library/utility/gpu_verification.hpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
#include "ck/host_utility/hip_check_error.hpp"
1919
#include "ck/library/utility/check_err.hpp"
2020

21+
#pragma clang diagnostic push
22+
#pragma clang diagnostic ignored "-Wlifetime-safety-intra-tu-suggestions"
2123
namespace ck {
2224
namespace profiler {
2325

@@ -517,3 +519,4 @@ float gpu_reduce_max(Iterator device_buffer, std::size_t size, hipStream_t strea
517519

518520
} // namespace profiler
519521
} // namespace ck
522+
#pragma clang diagnostic pop

‎include/ck/tensor_operation/gpu/device/impl/device_batched_contraction_multiple_d_wmma_cshuffle_v3.hpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
#include "ck/host_utility/kernel_launch.hpp"
2020
#include "ck/utility/scheduler_enum.hpp"
2121

22+
#pragma clang diagnostic push
23+
#pragma clang diagnostic ignored "-Wlifetime-safety-intra-tu-suggestions"
2224
namespace ck {
2325

2426
template <typename DeviceOp,
@@ -974,3 +976,4 @@ struct DeviceBatchedContractionMultipleD_Wmma_CShuffle_V3
974976
} // namespace device
975977
} // namespace tensor_operation
976978
} // namespace ck
979+
#pragma clang diagnostic pop

‎include/ck/tensor_operation/gpu/device/impl/device_batched_contraction_multiple_d_xdl_cshuffle.hpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
#include "ck/host_utility/device_prop.hpp"
1919
#include "ck/host_utility/kernel_launch.hpp"
2020

21+
#pragma clang diagnostic push
22+
#pragma clang diagnostic ignored "-Wlifetime-safety-intra-tu-suggestions"
2123
namespace ck {
2224

2325
template <typename GridwiseGemm,
@@ -1097,3 +1099,4 @@ struct DeviceBatchedContractionMultipleD_Xdl_CShuffle
10971099
} // namespace device
10981100
} // namespace tensor_operation
10991101
} // namespace ck
1102+
#pragma clang diagnostic pop

‎include/ck/tensor_operation/gpu/device/impl/device_batched_gemm_multi_d_xdl.hpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
#include "ck/host_utility/kernel_launch.hpp"
1919
#include "ck/host_utility/io.hpp"
2020

21+
#pragma clang diagnostic push
22+
#pragma clang diagnostic ignored "-Wlifetime-safety-intra-tu-suggestions"
2123
namespace ck {
2224
namespace tensor_operation {
2325
namespace device {
@@ -770,3 +772,4 @@ struct DeviceBatchedGemmMultiD_Xdl : public DeviceBatchedGemmMultiD<ALayout,
770772
} // namespace device
771773
} // namespace tensor_operation
772774
} // namespace ck
775+
#pragma clang diagnostic pop

0 commit comments

Comments
 (0)