[CK TILE ENGINE] CI fix for Basic Tile Engine#3554
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses CI issues in the Basic Tile Engine by removing unused commented-out code and simplifying the control flow in the GEMM instance builder.
Changes:
- Commented out unused "Run" lambda function and memory operation code
- Removed the SplitK handler code that was dispatching based on
k_batch - Simplified the closing braces structure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ThruptiRajLakshmanaGowda
requested review from
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent and
vidyasagar-amd
as code owners
tenpercent
approved these changes
Jan 14, 2026
Contributor
tenpercent
left a comment
tenpercent
left a comment
There was a problem hiding this comment.
based on the discussion, this shouldn't add more than 6 minutes to CI
illsilin
approved these changes
Jan 14, 2026
shumway
pushed a commit
that referenced
this pull request
Jan 15, 2026
* memory op changes * memory op changes * Fixing TILE_ENGINE_BASIC in Tile Engine * Removing gfx90a from Tile Engine Run * [CK TILE ENGINE] increasing ci configs for BASIC case * Setting RUN_TILE_ENGINE_BASIC_TESTS to ON by default --------- Co-authored-by: Max Podkorytov <4273004+tenpercent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR addresses CI issues in the Basic Tile Engine and enables Basic Tile Engine flow in CI, along with cascading changes in correspondence to #3359
Changes:
Removes Run function in GEMM kernel genration
Removed the SplitK handler code that was dispatching based on k_batch
Enabled Basic Tile Engine flow in CI by default to ON
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered