Skip to content

Batched gemm softmax gemm descriptor fix#3564

Merged
illsilin merged 3 commits into
developfrom
batched_gemm_softmax_gemm_descriptor_fix
Jan 20, 2026
Merged

Batched gemm softmax gemm descriptor fix#3564
illsilin merged 3 commits into
developfrom
batched_gemm_softmax_gemm_descriptor_fix

Conversation

@music-dino
Copy link
Copy Markdown
Contributor

Proposed changes

This change is needed for MIGraphX

c0_matrix_mask was being constructed with the wrong value, which lead to incorrect softmax calculation for anything but non-square inputs.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

@illsilin illsilin merged commit 6300ad3 into develop Jan 20, 2026
28 of 30 checks passed
@illsilin illsilin deleted the batched_gemm_softmax_gemm_descriptor_fix branch January 20, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants