Skip to content

Commit 8d6b4f1

Browse files
author
Atturu
committed
Enclose user and group names in quotes
This is to ensure user/group names with spaces are treated as a single argument
1 parent f64bbc3 commit 8d6b4f1

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

tools/deb/base-image/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
all:
22
@if [ -n "$(INSECURE_REGISTRY)" ]; then \
33
echo "building dev container with insecure registry" ;\
4-
docker build --build-arg USER=$(shell id -un) --build-arg GROUP=$(shell id -gn) \
4+
docker build --build-arg USER="$(shell id -un)" --build-arg GROUP="$(shell id -gn)" \
55
--build-arg BUILD_BASE_IMAGE=$(BUILD_BASE_IMAGE) \
66
--build-arg INSECURE_REGISTRY=$(INSECURE_REGISTRY) \
77
--build-arg UID=$(shell id -u) --build-arg GID=$(shell id -g) -t ${BUILD_CONTAINER} . ;\
88
else \
99
echo "building dev container without insecure registry" ;\
10-
docker build --build-arg USER=$(shell id -un) --build-arg GROUP=$(shell id -gn) \
10+
docker build --build-arg USER="$(shell id -un)" --build-arg GROUP="$(shell id -gn)" \
1111
--build-arg BUILD_BASE_IMAGE=$(BUILD_BASE_IMAGE) \
1212
--build-arg UID=$(shell id -u) --build-arg GID=$(shell id -g) -t ${BUILD_CONTAINER} . ;\
1313
fi

tools/rpmbuild/base-image/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
all:
22
@if [ -n "$(INSECURE_REGISTRY)" ]; then \
33
echo "building rpmbuild dev container with insecure registry" ;\
4-
docker build --build-arg USER=$(shell id -un) --build-arg GROUP=$(shell id -gn) \
4+
docker build --build-arg USER="$(shell id -un)" --build-arg GROUP="$(shell id -gn)" \
55
--build-arg BUILD_BASE_IMAGE=$(BUILD_BASE_IMAGE) \
66
--build-arg INSECURE_REGISTRY=$(INSECURE_REGISTRY) \
77
--build-arg UID=$(shell id -u) --build-arg GID=$(shell id -g) -t ${RPM_BUILD_CONTAINER} . ;\
88
else \
99
echo "building rpmbuild dev container without insecure registry" ;\
10-
docker build --build-arg USER=$(shell id -un) --build-arg GROUP=$(shell id -gn) \
10+
docker build --build-arg USER="$(shell id -un)" --build-arg GROUP="$(shell id -gn)" \
1111
--build-arg BUILD_BASE_IMAGE=$(BUILD_BASE_IMAGE) \
1212
--build-arg UID=$(shell id -u) --build-arg GID=$(shell id -g) -t ${RPM_BUILD_CONTAINER} . ;\
1313
fi

0 commit comments

Comments
 (0)