Merge pull request #61 from ROCm/enrootdocs

Fix for #59

Author: sgopinath1

README.md

@@ -6,6 +6,7 @@ AMD Container Toolkit offers tools to streamline the use of AMD GPUs with contai
 # Requirements
 - Ubuntu 22.02 or 24.04, or RHEL/CentOS 9
 - Docker version 25 or later
+- All the 'amd-ctk runtime configure' commands should be run as root/sudo
 
 # Quick Start
 Install the Container toolkit.
@@ -131,6 +132,7 @@ To install the AMD Container Toolkit on RHEL/CentOS 9 systems, follow these step
      ```
 
 3. List available GPUs.
+If this command is run as root, the container-toolkit logs go to /var/log/amd-container-runtime.log, otherwise they go to the user's home directory.
 
 ```text
 > amd-ctk cdi list

internal/logger/logger.go

@@ -19,6 +19,7 @@ package logger
 import (
 	"log"
 	"os"
+	"os/user"
 	"path/filepath"
 	"sync"
 )
@@ -42,17 +43,32 @@ func SetLogFile(file string) {
 }
 
 // SetLogDir sets the path to the directory of logs
-func SetLogDir(dir string) {
-	logdir = dir
+func SetLogDir() {
+	if os.Getenv("LOGDIR") != "" {
+		logdir = os.Getenv("LOGDIR")
+		return
+	}
+	// Get the current user's information.
+	currentUser, err := user.Current()
+	if err != nil {
+		log.Fatalf("Failed to get current user: %v", err)
+	}
+	// for root user, log dir is /var/log
+	if currentUser.Uid != "0" {
+		//Non-Root user, setting log directory to user's home directory
+		homeDir, err := os.UserHomeDir()
+		if err != nil {
+			log.Fatalf("Failed to get user home directory: %v", err)
+		}
+		logdir = homeDir
+	}
 }
 
 func initLogger(console bool) {
 	if console {
 		Log = log.New(os.Stdout, logPrefix, log.Lmsgprefix)
 	} else {
-		if os.Getenv("LOGDIR") != "" {
-			logdir = os.Getenv("LOGDIR")
-		}
+		SetLogDir()
 
 		outfile, err := os.OpenFile(filepath.Join(logdir, logfile),
 			os.O_CREATE|os.O_APPEND|os.O_WRONLY, 0666)