[ci] Deprecate hipcc: use amdclang++ as default compiler by david-salinas · Pull Request #20 · ROCm/libhipcxx

david-salinas · 2026-05-08T17:21:18Z

Description

The HIPCC Tool will be deprecated, and eventually removed in an upcoming release. Users will be directed to use amdclang++ instead and will be given a migration guide.

closes
Jira: https://amd-hub.atlassian.net/browse/ROCM-8370

Replace the hipcc fallback defaults for HOST_COMPILER and CUDA_COMPILER with amdclang++. hipcc is deprecated in favor of calling amdclang++ directly with explicit --hip-path and --hip-device-lib-path flags.

Callers that set $CXX or $CUDACXX are unaffected.

Checklist

New or existing tests cover these changes.
The documentation is up to date with these changes.

…mon.sh Replace the hipcc fallback defaults for HOST_COMPILER and CUDA_COMPILER with amdclang++. hipcc is deprecated in favor of calling amdclang++ directly with explicit --hip-path and --hip-device-lib-path flags. Callers that set $CXX or $CUDACXX are unaffected.

With amdclang++ used directly (not hipcc), the bare `hiprtc` link dependency has no library search path and fails with: ld.lld: error: unable to find library -lhiprtc Switch to find_package(hiprtc CONFIG) and link hiprtc::hiprtc, which carries the full library path via IMPORTED_LOCATION. Also switch find_package(HIP) to find_package(hip CONFIG) for consistency. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

…X_FLAGS CMAKE_CXX_FLAGS=-x hip gets passed to the linker step too, causing amdclang++ to try to parse ELF object files as HIP source: error: expected unqualified-id (reading ELF magic bytes) Move -x hip to target_compile_options on the version_check target so it only applies during compilation, not linking. Remove it from the global cmake_opts passed to the sub-project configure step. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

lamb-j · 2026-06-24T15:25:46Z

+HOST_COMPILER=${CXX:-amdclang++} # $CXX if set, otherwise `amdclang++`
 CXX_STANDARD=17
-CUDA_COMPILER=${CUDACXX:-hipcc} # $CUDACXX if set, otherwise `nvcc`
+CUDA_COMPILER=${CUDACXX:-amdclang++} # $CUDACXX if set, otherwise `amdclang++`


Can we use amdclang as the CUDA compiler?

ok yeah, we need to replicate the logic in hipcc to call amdclang++ or nvcc depending on the HIP_PLATFORM value. I'll get a patch to fix this, and see if there are other cases in theRock were we need to do that too.

…ng++/nvcc Replace the hardcoded HIP_HIPCC_EXECUTABLE reference in the upstream test CMakeLists.txt with direct compiler selection that mirrors hipcc's own platform detection logic: - HIP_PLATFORM=nvidia or HIP_PLATFORM=nvcc -> use nvcc - Everything else (including unset, the AMD default) -> use amdclang++ via CMAKE_CXX_COMPILER Also update ci/build_common.sh to apply the same HIP_PLATFORM-based logic when defaulting CUDA_COMPILER, replacing the unconditional amdclang++ default. Set CMAKE_CUDA_COMPILER_ID to "Clang" for the AMD path (was "HIPCC") so that compiler warning flag logic downstream behaves correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

david-salinas · 2026-06-29T18:35:46Z

I'm working with Sivakumar from CI to do a one-off CI run of these changes for libhipcxx: https://github.com/ROCm/llvm-project/actions/runs/28262379561/job/83747072584 I'll update when we have a full/clean run.

Pin-only SMP bump for one-off CI validation of ROCm/libhipcxx#20.

Setting it to "Clang" routes into the Clang/CUDA branch of the test infrastructure CMakeLists which unconditionally appends -lcudart to linker flags. On AMD-only CI there is no CUDA runtime, so the link fails. Keep "HIPCC" so the HIP-specific flags branch is taken instead. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>

CMAKE_CUDA_COMPILER_ID "HIPCC" was a misnomer in two places: - AMD amdclang++ path: rename to "AMDCLANG" to reflect the actual compiler - HIPRTC path: rename to "HIPRTC" to reflect the hiprtcc binary Update the flag branch check to match both new IDs so both paths continue to get HIP include dirs without pulling in -lcudart. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>

NVRTC/HIPRTC indicate which runtime to link against, not which compiler to use. Previously, hipcc inferred the compiler from HIP_PLATFORM; now we do it explicitly in CMake. - LIBCUDACXX_TEST_WITH_NVRTC -> NVCC - LIBHIPCXX_TEST_WITH_HIPRTC -> AMDCLANG (AMD runtime = AMD compiler) CMAKE_CUDA_COMPILER_ID now has exactly two values: "NVCC" or "AMDCLANG". Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>

Consistent with the offline NVIDIA path and the existing "NVIDIA" branch in the linker flags section. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>

Pin-only SMP bump for one-off CI validation of ROCm/libhipcxx#20.

hipcc previously added the HIP runtime library automatically. With amdclang++ invoked directly, we must link it explicitly. Derive the library path from the hip::amdhip64 imported target so it works regardless of install prefix. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>

Two fixes needed when building with amdclang++ directly: 1. cmake/test/CMakeLists.txt: propagate CMAKE_PREFIX_PATH into the sub-cmake invocations used by the test_export tests so they can find hipConfig.cmake. 2. cmake/test/test_export/CMakeLists.txt: add -x hip to version_check so libhipcxx headers that use __host__/__device__ compile correctly without going through hipcc. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>

Pin-only SMP bump for one-off CI validation of ROCm/libhipcxx#20.

lamb-j · 2026-07-05T23:19:35Z

-  set(CMAKE_CUDA_COMPILER_ID "HIPCC")
+  # HIPRTC is the AMD runtime; use the same HIP_PLATFORM-based compiler
+  # selection as the offline compilation path below.
+  set(CMAKE_CUDA_COMPILER_ID "AMDCLANG")


Should we even be setting CUDA_COMPILER for hipRTC?

We do have cursory support for CUDA compiler support in the HIPRT. Normally hipcc would invoke nvcc based on HIP_PLATFORM=nvidia, or amdclang if HIP_PLATFORM=amd. Because we're removing calls to hipcc, we need to mimic that behaviour in the cmake files.

lamb-j · 2026-07-05T23:20:04Z

+    # Select compiler based on HIP_PLATFORM env var, mirroring hipcc's own
+    # platform detection logic. HIP_PLATFORM=nvidia uses nvcc; everything
+    # else (including the default unset case) uses amdclang++ directly.


Shorten/remove this comment; no need to have historical references to hipcc

lamb-j · 2026-07-05T23:20:42Z

+  # hipcc used to add the HIP runtime library automatically; with amdclang++
+  # we must link it explicitly.


I'd remove this comment

lamb-j

Overall looks good. I'm wondering how needed all of the tie-ins to CUDA/nvcc are

Obv we need one of the libhipcxx reviewers to weigh in.

Thanks for putting this together!

On Windows the import library (.lib) is in lib/ while the DLL is in bin/. Using LOCATION gives the DLL path (bin/), so the linker can't find amdhip64.lib. Use IMPORTED_IMPLIB instead to get the .lib path directly, falling back to LOCATION on Linux. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>

…B variants IMPORTED_IMPLIB is not set; CMake uses config-specific variants like IMPORTED_IMPLIB_RELEASE. Try all variants; if none are set, derive lib/ from the DLL location in bin/ by going up one directory level. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>

david-salinas marked this pull request as draft May 8, 2026 17:22

david-salinas force-pushed the users/dsalinas/deprecate-hipcc branch from ffd7b4d to 94b24f1 Compare May 13, 2026 22:13

david-salinas and others added 3 commits May 17, 2026 14:55

david-salinas force-pushed the users/dsalinas/deprecate-hipcc branch from 94b24f1 to e7c63ea Compare May 17, 2026 19:55

lamb-j mentioned this pull request May 26, 2026

[test-only] [PATCHES] Deprecate HIPCC ROCm/TheRock#5081

Draft

1 task

david-salinas marked this pull request as ready for review June 24, 2026 15:16

david-salinas requested a review from lamb-j June 24, 2026 15:16

lamb-j reviewed Jun 24, 2026

View reviewed changes

david-salinas requested review from monoatamd and obersteiner June 29, 2026 18:33

skganesan008 added a commit to ROCm/TheRock that referenced this pull request Jun 29, 2026

[test-only] Bump libhipcxx to 95241b0 (deprecate hipcc)

341fd43

Pin-only SMP bump for one-off CI validation of ROCm/libhipcxx#20.

skganesan008 mentioned this pull request Jun 29, 2026

[test-only] Bump libhipcxx to 95241b0 (deprecate hipcc) ROCm/TheRock#6231

Open

1 task

david-salinas and others added 4 commits June 30, 2026 12:35

[libhipcxx] Use NVIDIA (not NVCC) as compiler ID for NVRTC path

55c12d3

Consistent with the offline NVIDIA path and the existing "NVIDIA" branch in the linker flags section. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>

skganesan008 added a commit to ROCm/TheRock that referenced this pull request Jun 30, 2026

[test-only] Bump libhipcxx to 55c12d3 (deprecate hipcc)

998ab90

Pin-only SMP bump for one-off CI validation of ROCm/libhipcxx#20.

david-salinas and others added 2 commits July 1, 2026 10:01

skganesan008 added a commit to ROCm/TheRock that referenced this pull request Jul 1, 2026

[test-only] Bump libhipcxx to a590fcd (deprecate hipcc)

c7bfbab

Pin-only SMP bump for one-off CI validation of ROCm/libhipcxx#20.

lamb-j reviewed Jul 5, 2026

View reviewed changes

lamb-j approved these changes Jul 5, 2026

View reviewed changes

Address PR Comments.

6c9961a

david-salinas requested a review from lamb-j July 8, 2026 15:53

david-salinas and others added 2 commits July 13, 2026 15:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ci] Deprecate hipcc: use amdclang++ as default compiler#20

[ci] Deprecate hipcc: use amdclang++ as default compiler#20
david-salinas wants to merge 13 commits into
amd-developfrom
users/dsalinas/deprecate-hipcc

david-salinas commented May 8, 2026 •

edited

Loading

Uh oh!

lamb-j Jun 24, 2026

Uh oh!

david-salinas Jun 24, 2026

Uh oh!

david-salinas commented Jun 29, 2026

Uh oh!

lamb-j Jul 5, 2026

Uh oh!

david-salinas Jul 7, 2026

Uh oh!

lamb-j Jul 5, 2026

Uh oh!

david-salinas Jul 7, 2026

Uh oh!

lamb-j Jul 5, 2026

Uh oh!

david-salinas Jul 7, 2026

Uh oh!

lamb-j left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		# hipcc used to add the HIP runtime library automatically; with amdclang++
		# we must link it explicitly.

Uh oh!

Conversation

david-salinas commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

david-salinas commented Jun 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lamb-j left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

david-salinas commented May 8, 2026 •

edited

Loading