OpenMP divergence: Remove unused argument from getTargetFeatures#3057
Merged
arsenm merged 2 commits intoJul 8, 2026
Merged
Conversation
The signature now at least should match upstream, avoiding an upcoming merge conflict. The content is still divergent.
Author
|
ping |
1 similar comment
Author
|
ping |
jhuber6
approved these changes
Jul 7, 2026
ronlieb
approved these changes
Jul 7, 2026
…AMDGPUTargetFeatures-signature
Collaborator
|
rock CI seems to be not triggered at all. Let me close and reopen this PR. |
auto-merge was automatically disabled
July 7, 2026 20:33
Pull request was closed
arsenm
deleted the
arsenm/openmp-upstream-divergence-getAMDGPUTargetFeatures-signature
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature now at least should match upstream, avoiding an upcoming merge conflict. The content is still divergent.