[CI][Security] ROCM-26580: Add integrity checks to Windows CI Dockerfile#3105
Open
vkallesh wants to merge 1 commit into
Open
[CI][Security] ROCM-26580: Add integrity checks to Windows CI Dockerfile#3105vkallesh wants to merge 1 commit into
vkallesh wants to merge 1 commit into
Conversation
…ows CI Dockerfile Fix for ROCM-26580 (SEC-00399) - CI Dockerfiles Fetch and Execute Remote Content Without Integrity Verification Including Plain HTTP Issue: Windows CI container image downloads and executes installers without checksum verification. Uses HTTP for GitHub release downloads and weak MD5 checksums. Vulnerable to supply chain attacks via MITM or compromised download servers. Impact: Compromised build tools could backdoor all builds, affecting thousands of downstream users. MD5 collisions are trivial to create. Solution: 1. Added SHA-256 integrity verification for all downloads: - VS Build Tools: 15bc8cfc727e099aaba861eb21a811776bcbddc603c0a3f203eba5e5a7710421 - VS Channel: 77c4e66845042ed147d0abb95c52a5dfbb505fc14949d9f277c3fb01f7c54830 - GitHub Actions Runner (v2.335.0): 0422df90994cc5e2350238fb2707029fddaa156e7e4562b14e35086f94417e87 - XZ Utils (v5.8.1): 62fdfde73d5c5d293bbb4a96211b29d09adbd56bc6736976e4c9fc9942ae3c67 - LLVM/Clang (v22.1.4): ed775bdaea7087c6c1aeac9498352cfcd8610d92dc4fe9eda9aecb15ce712a2c 2. Changed all http://github.com URLs to https:// 3. Replaced MD5 with SHA-256 (MD5 is cryptographically broken) 4. Added error handling - build fails if hash mismatch detected 5. All SHA-256 hashes obtained by downloading files and computing checksums on 2026-06-28. Verification details documented in security_reported_bugs/ROCM-26580-hash-verification.md Files modified: - .github/workflows/containers/github-action-ci-windows/Dockerfile JIRA: https://amd-hub.atlassian.net/browse/ROCM-26580
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for ROCM-26580 (SEC-00399) - CI Dockerfiles Fetch and Execute Remote
Content Without Integrity Verification Including Plain HTTP
Issue: Windows CI container image downloads and executes installers
without checksum verification. Uses HTTP for GitHub release downloads
and weak MD5 checksums. Vulnerable to supply chain attacks via MITM or
compromised download servers.
Impact: Compromised build tools could backdoor all builds, affecting
thousands of downstream users. MD5 collisions are trivial to create.
Solution:
checksums on 2026-06-28.